-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fixed account description text field in account settings #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed account description text field in account settings #1256
Conversation
e5f9982 to
4dcead0
Compare
|
I think this is already fixed by #1249 ? That branch works in my testing |
|
That is correct but I might prefer this approach. I'll do some testing to verify. |
|
The question is, which approach to this problem to we prefer? Do we want to change the struct to a class as done in this PR or do we want to create a parallel state variable in the view as I have done here? Both are not pretty solutions in my opinion. Maybe there is another option we aren't considering, who knows. Notice I use this state variable thought the file and when this state variable gets any updates it sets the settings variable like this. I know @CippoX put work into this PR and I really appreciate that, but I am interested in the pattern we want to continue with moving forward and what is best for the project overall. Anyone have any thoughts on this. |
|
My understanding is that changing the variable to |
I also did some researches on this problem, as @CippoX mentioned, |
|
After speaking with several maintainers, we've concluded that the we'd like to keep Settings all structs for consistency. This is my primary concern with this PR here. I agree with the idea that it should use |
Description
Changed
SourceControlAccountas a class that conforms to ObservableObject, sovar description: Stringis now@Published.This is just an attempt. As a beginner, I don't know if this is the right way to fix the problem.
Related Issues
Checklist
Screenshots
Registrazione.schermo.2023-05-02.alle.15.06.05.mov