Fix status bar preventing window resizing #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #177 by replacing the
.fixedSize()modifier from the largest status bar item with.fixedSize(horizontal: false, vertical: true). The.fixedSize()was causing the sidebar to stay the same width even when the window needed to shrink to a smaller width.PR #193 fixed this by removing the long error message that was causing the problem, but this PR removes the underlying layout problem. This will also fix the issue if someone in the future has a very long branch name.
Also, as you can see in the screen recording, it fixes this bug when other long errors are present.
Releated Issue
PR #193 and issue #177
Checklist (for drafts):
Screenshots (if appropriate):
Status bar item resizing with width change:
Screen.Recording.2022-03-22.at.7.35.31.PM.mov