Skip to content

Conversation

@lukepistrol
Copy link
Member

@lukepistrol lukepistrol commented Mar 22, 2022

Description

Fixes issue #178.
Now shows No Git Repository instead of fatal: not a git repository (or any of the parent directories): git and disables the picker.
Also the pull button is disabled.

Hides the branch picker & pull button when no git repo is present

Releated Issue

#178

Checklist (for drafts):

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • Review requested

Screenshots (if appropriate):

Screen Shot 2022-03-23 at 00 52 24

@lukepistrol lukepistrol added bug Something isn't working UI This is UI related labels Mar 22, 2022
@lukepistrol lukepistrol requested a review from 0xWDG March 22, 2022 23:21
@lukepistrol lukepistrol linked an issue Mar 22, 2022 that may be closed by this pull request
@lukepistrol lukepistrol changed the title quick-fix Fatal not a git repository Fix Fatal not a git repository Mar 22, 2022
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just hide it entirely instead of disabling it

@lukepistrol
Copy link
Member Author

Fixed it @austincondiff

@lukepistrol lukepistrol requested review from austincondiff and removed request for 0xWDG March 23, 2022 00:05
@lukepistrol lukepistrol merged commit 195de4f into CodeEditApp:main Mar 23, 2022
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI This is UI related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Fatal not a git repository

2 participants