🐞 Line number font is incorrect

[austincondiff]

The line number font does not align with Xcode.

Left: Xcode | Right: CodeEdit

The font needs to be sans-serif, narrower, with the color less prominent.

[lukepistrol]

Just want to leave this here. Did some research a while back and this might help:

private var lineGutterFont: NSFont {
    let fontSize: Double = 10

    // TODO: calculate the font size depending on the editors font size.
    let font = NSFont.monospacedSystemFont(ofSize: fontSize, weight: .medium)

    let alt0NoSlash: [NSFontDescriptor.FeatureKey: Int] = [
        .selectorIdentifier: 6,
        .typeIdentifier: kStylisticAlternativesType,
    ]

    let alt1NoSerif: [NSFontDescriptor.FeatureKey: Int] = [
        .selectorIdentifier: 8,
        .typeIdentifier: kStylisticAlternativesType,
    ]

    let descriptor = font.fontDescriptor.addingAttributes([.featureSettings: [alt0NoSlash, alt1NoSerif]])

    return NSFont(descriptor: descriptor, size: 0) ?? font
}

[austincondiff]

That gets me the alternate characters like the open 4 however I still need to be able to reduce the width and tracking. Any idea how I might do that?

[lukepistrol]

That gets me the alternate characters like the open 4 however I still need to be able to reduce the width and tracking. Any idea how I might do that?

Maybe something here

[ben-p-commits]

@austincondiff, @lukepistrol - I believe the font you're looking for is actually sneakily bundled into Xcode.

take a look in: /Applications/Xcode.app/Contents/SharedFrameworks/DVTUserInterfaceKit.framework/Versions/A/Resources/Fonts

and say hello to this little guy:
XcodeDigits-regular.ttf

I would guess that it's proprietary.

[austincondiff]

I am aware of Xcode Digits after digging through the app contents. I have thought about sneaking it in, but probably not as I think you are right in that it might be proprietary (not clear if it is or isn't). I think we can get a look like this with the SF variable font (not sure if we can use it now or if we need to wait).

[ben-p-commits]

Looks like variable fonts are only available in OS 13+...

https://developer.apple.com/documentation/appkit/nsfont/width?changes=latest_3_5_2

[austincondiff]

We will be using ExtensionKit and the new form style in Settings. The though it once we are out of beta, 13 will be standard by that point. So I'd say let's try to achieve the same look with variable fonts!

[austincondiff]

@ben-p-commits we will be increasing our minimum target to macOS 13 if you wanted to take a stab at doing this via variable fonts.

[ben-p-commits]

I just updated to ventura- happy to dive back in!

…

On Thu, Feb 16, 2023 at 6:30 PM Austin Condiff ***@***.***> wrote: @ben-p-commits <https://github.com/ben-p-commits> we will be increasing our minimum target to macOS 13 if you wanted to take a stab at doing this via variable fonts. — Reply to this email directly, view it on GitHub <CodeEditApp/CodeEditTextView#58 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGVDZJTIPDW7RS4TQ5BD43WX22BTANCNFSM6AAAAAAQMVPYSY> . You are receiving this because you were mentioned.Message ID: ***@***.***>