Skip to content

Make Ruler look more like Xcode by creating custom font. Make ruler font and ruler Inset scale with text font size. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukepistrol merged 4 commits into from
Mar 26, 2023
Merged

Make Ruler look more like Xcode by creating custom font. Make ruler font and ruler Inset scale with text font size. #170

lukepistrol merged 4 commits into from
Mar 26, 2023

Conversation

@Eliulm
Copy link
Contributor

@Eliulm Eliulm commented Mar 26, 2023 •
edited by lukepistrol
Loading

Description

This PR adds a customized SF Pro Font which aims to look like the Xcode Digits font.
The ruler font and the ruler insets scale with the text font size.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

PointSize 13:
Xcode left, CodeEdit Right:
image

PointSize 20:
Xcode left, CodeEdit Right:
image

lukepistrol
lukepistrol reviewed Mar 26, 2023
View reviewed changes
austincondiff
austincondiff previously approved these changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just fix that comment typo

@Eliulm
Update Sources/CodeEditTextView/Extensions/NSFont+RulerFont.swift
a936a4a 
Co-authored-by: Lukas Pistrol <l.pistrol@gmail.com>
lukepistrol
lukepistrol approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@lukepistrol lukepistrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 😊

@lukepistrol lukepistrol merged commit a60580a into CodeEditApp:main Mar 26, 2023
@luah5 luah5 mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukepistrol lukepistrol lukepistrol approved these changes

@austincondiff austincondiff austincondiff left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨ Scale line numbers relative to font size 🐞 Line number font is incorrect

3 participants

@Eliulm @austincondiff @lukepistrol