Skip to content

Script List Reorder Fix#24

Closed
lucho-suaya wants to merge 2 commits intoCodeNameTwister:devfrom
lucho-suaya:script_list_reorder_fix
Closed

Script List Reorder Fix#24
lucho-suaya wants to merge 2 commits intoCodeNameTwister:devfrom
lucho-suaya:script_list_reorder_fix

Conversation

@lucho-suaya
Copy link

Hi! I'm using this tool, which I think it's great, thanks! :D

I noticed that the reorder functionality of the script list panel in the left (base functionality from Godot) is somehow broken? So scripts can no longer be reordered when dragging them in that list.

I made a bit of a nasty fix by listening the signal _script_list.gui_input in list.gd and adding a function that does the script reorder. I don't 100% like it because it looks a bit ugly and probably can be fixed easily using whatever base functionality there is without overriding anything, but I did it fast and without having enough time to focus on how it actually all works. Though, if you want it, it's all yours :)

I also saw there are a couple of broken dependencies in Pin.tscn likely coming from a rename done some time ago, so I also fixed them :)
Thanks! :D

PS: Btw, I'd really like to see a couple of features (creating splits if dragging from this script list and also if dragging from the top tabs bar), should I add them as enhancement issues?

CodeNameTwister added a commit that referenced this pull request Jan 3, 2026
- Fixed: Script List Reorder Fix #24
- More Optimization.
- Fixed: Drag/Move for tabs (for the new behaviour)
@CodeNameTwister
Copy link
Owner

Thanks, I'd forgotten to finish the reordering implementation.

I tested your code and it works perfectly. Because the add-on works with container splitting, I had to modify the idea.

As for Pin.tscn, it was a feature for a new type of pinned tab display that was actually discarded.

full update 3a4a91d

PS: Btw, I'd really like to see a couple of features (creating splits if dragging from this script list and also if dragging from the top tabs bar), should I add them as enhancement issues?

I might implement that functionality in the next update, but since I'm busy, the update will take some time so I'll create a new issue mentioning this pull.

@lucho-suaya
Copy link
Author

Cool! Thanks for taking care of it so quick, I should have imagined that the implementation was actually more complex than I thought.

About the request, thanks! I'll keep track of the updates and merge them to my projects :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants