Skip to content

Script List Reorder Fix #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucho-suaya wants to merge 2 commits into from
Closed

Script List Reorder Fix #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd2c61
Implemented drag and drop reorder of script list in script editor
lucho-suaya Oct 27, 2025
291378a
Fixed broken dependencies in Pin.tscn (likely coming from renaming)
lucho-suaya Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions addons/script_splitter/core/base/list.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ func _init(list : ItemList) -> void:
_script_list.item_activated.connect(_on_sc_item_activate)
_script_list.item_clicked.connect(_on_sc_item_clicked)
#_editor_list.draw.connect(_on_update_list)
_script_list.gui_input.connect(_on_script_list_gui_input)

_script_list.add_to_group(&"__SP_LT__")
_array_list = [_editor_list, _script_list]
Expand Down Expand Up @@ -184,6 +185,37 @@ func _on_update_list_search(txt : String) -> void:

update_list_selection()

func _on_script_list_gui_input(event: InputEvent) -> void:
# Handle drag and drop for script list reordering
if event is not InputEventMouseMotion or not Input.is_mouse_button_pressed(MOUSE_BUTTON_LEFT):
return

var script_editor: ScriptEditor = EditorInterface.get_script_editor()
if !is_instance_valid(_script_list) or !is_instance_valid(_editor_list) or !is_instance_valid(script_editor):
return

var hovered_item: int = _script_list.get_item_at_position(_script_list.get_local_mouse_position(), true)
var selected_items: PackedInt32Array = _script_list.get_selected_items()
if hovered_item < 0 or selected_items.size() <= 0:
return

var selected_item: int = selected_items[0]
if hovered_item == selected_item:
return

# Move the duplicate first and then the original (for persistence)
_script_list.move_item(selected_item, hovered_item)
if _editor_list.item_count > selected_item and _editor_list.item_count > hovered_item:
_editor_list.move_item(selected_item, hovered_item)

# Find the editor TabContainer that matches our item count
var editors: Array[Node] = script_editor.find_children("*", "TabContainer", true, false)
for tab_container: TabContainer in editors:
if tab_container.get_child_count() == _editor_list.item_count:
if tab_container.get_child_count() > selected_item and tab_container.get_child_count() > hovered_item:
tab_container.move_child(tab_container.get_child(selected_item), hovered_item)
break

func update_list_selection() -> void:
if update_selections_callback.is_valid():
update_selections_callback.call(_array_list)
Expand Down
6 changes: 3 additions & 3 deletions addons/script_splitter/core/ui/pin/Pin.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[gd_scene load_steps=4 format=3 uid="uid://cnbyjwmktxipx"]

[ext_resource type="Script" uid="uid://w8t1dg3mooti" path="res://addons/script_spliter/core/ui/pin/control.gd" id="1_2gb5h"]
[ext_resource type="Script" uid="uid://cl3i4qjav3ikw" path="res://addons/script_spliter/core/ui/pin/root.gd" id="1_e0xng"]
[ext_resource type="Script" uid="uid://c34ix3uq8fdae" path="res://addons/script_spliter/core/ui/pin/pin.gd" id="1_ulj15"]
[ext_resource type="Script" uid="uid://w8t1dg3mooti" path="res://addons/script_splitter/core/ui/pin/control.gd" id="1_2gb5h"]
[ext_resource type="Script" uid="uid://cl3i4qjav3ikw" path="res://addons/script_splitter/core/ui/pin/root.gd" id="1_e0xng"]
[ext_resource type="Script" uid="uid://c34ix3uq8fdae" path="res://addons/script_splitter/core/ui/pin/pin.gd" id="1_ulj15"]

[node name="Control" type="Control"]
layout_mode = 3
Expand Down