Skip to content

Conversation

@cjyuan
Copy link
Contributor

@cjyuan cjyuan commented May 19, 2025

Changelist

  • Added "No review required" note in README.md
  • Changed PR template
    1. Made it more like the PR template we used in all modules
    2. Added comments to instruct learners how to prepare a PR description

@cjyuan
Copy link
Contributor Author

cjyuan commented May 19, 2025

We only discussed "add a 'no review required' note' to README.md last week.

If you think the proposed PR template is better than the original one. I will apply both changes to https://github.com/CodeYourFuture/GitHomeworkTest as well.

@cjyuan cjyuan requested a review from illicitonion May 19, 2025 16:22
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion - thanks!

Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
@cjyuan
Copy link
Contributor Author

cjyuan commented May 19, 2025

Applied your suggestion to make the "no review required" instruction clearer.

@illicitonion illicitonion merged commit bc07ccb into CodeYourFuture:main May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants