Skip to content

Added "No review required" note and changed PR template #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illicitonion merged 4 commits into from
May 20, 2025
Merged

Added "No review required" note and changed PR template #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
060c9c1
Add a "review not required" note
cjyuan May 19, 2025
d633615
Add new instructions to PR template
cjyuan May 19, 2025
00265b5
Update pull_request_template.md
cjyuan May 19, 2025
589c1a4
Apply Daniel's suggestion
cjyuan May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,34 @@

You must title your PR like this:

COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME

For example,

ITP-OCT-24 | Carol Owen | GitHomeworkFixErrors | Week1
London | May-2025 | Carol Owen | Sprint-1

Complete the task list below this message.
If your PR is rejected, check the task list.
-->

## Learners, PR Template
<!--
The purpose of the self-checklist is to help ensure the quality and completeness of a PR submission.

You must complete all the tasks in the self-checklist and tick the boxes for those you have finished.

You can tick a box by changing [ ] to [x] (with no spaces inside the brackets).
-->

# Your Details
Self checklist

- Your Name:
- Your City:
- Your Slack Name:
- [ ] I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
- [ ] My changes meet the requirements outlined in the `README.md` of this task

# Homework Details
## Changelist

- Module:
- Week:
<!--
When you submit a PR, you're submitting changes you made to your own copy (fork) of the repository and requesting a review of those changes.
It is best practice to leave a brief description of the changes you have made.

You must replace "Briefly explain your PR." with a brief description of the changes you have made.
-->
Briefly explain your PR.
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,9 @@ Can you help him to fix or improve the answers to his homework?
3. Create a branch with an appropriate name for the task you're on
3. Fix the errors in Linus's homework in `homework.md`
4. Create a Pull Request back to this repository with the correct answers. Make sure your Pull Request is created in CodeYourFuture's fork, not your personal fork.


## How to check your work?
If you have correctly submitted your PR, you can find it in https://github.com/CodeYourFuture/GitHomeworkFixErrors/pulls.

Please note that your PR will not undergo an official review, as none is required. Most PRs at CodeYourFuture get reviewed, but this one is just for you to practice creating them.