refactor: deprecate displayName, use name property (Android)#326
Merged
reslear merged 2 commits intoCodetrixStudio:masterfrom Nov 26, 2023
Merged
refactor: deprecate displayName, use name property (Android)#326reslear merged 2 commits intoCodetrixStudio:masterfrom
displayName, use name property (Android)#326reslear merged 2 commits intoCodetrixStudio:masterfrom
Conversation
Collaborator
|
good, maybe better to rename
closes #73 |
reslear
changed the title
displayName property
reslear
changed the title
displayName propertydisplayName, use name property (Android)
Collaborator
|
@itsLucario congratulations thanks for your contribution ;) |
Houssemtak89
pushed a commit
to Houssemtak89/CapacitorGoogleAuth
that referenced
this pull request
Dec 18, 2023
…etrixStudio#326) * fix: User should contain displayName property * unify and deprectate --------- Co-authored-by: reslear <reslear@gmail.com>
cpmsmith
pushed a commit
to fellowapp/CapacitorGoogleAuth
that referenced
this pull request
Nov 26, 2025
…etrixStudio#326) * fix: User should contain displayName property * unify and deprectate --------- Co-authored-by: reslear <reslear@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google SignIn result return "displayName" (Basically full name) but the User container property "name" which is never populated.
Ref:
CapacitorGoogleAuth/android/src/main/java/com/codetrixstudio/capacitor/GoogleAuth/GoogleAuth.java
Line 116 in 2b73c09
closes #73