Skip to content

refactor: deprecate displayName, use name property (Android) #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reslear merged 2 commits into from
Nov 26, 2023
Merged

refactor: deprecate displayName, use name property (Android) #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88b3a51
fix: User should contain displayName property
itsLucario Nov 26, 2023
b435924
unify and deprectate
reslear Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/src/main/java/com/codetrixstudio/capacitor/GoogleAuth/GoogleAuth.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ protected void signInResult(PluginCall call, ActivityResult result) {
user.put("idToken", account.getIdToken());
user.put("authentication", authentication);

user.put("name", account.getDisplayName());
// Deprecated: Use `user` instead of `displayName`
user.put("displayName", account.getDisplayName());
user.put("email", account.getEmail());
user.put("familyName", account.getFamilyName());
Expand Down
5 changes: 4 additions & 1 deletion src/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ declare module '@capacitor/cli' {
export interface User {
id: string;
email: string;

/**
* @deprecated use `name` instead
*/
displayName: string
name: string;
familyName: string;
givenName: string;
Expand Down