Update the README to use the correct chart repo#14
Update the README to use the correct chart repo#14ianconsolata wants to merge 1 commit intoCommunitySolidServer:feat/css-v5.0.0from
Conversation
https://communitysolidserver.github.io/css-helm-chart/charts/ -> this repo leads to a (very) outdated helm repo, served from this folder: https://github.com/CommunitySolidServer/css-helm-chart/tree/gh-pages/charts/. The `index.yaml` file in that folder hasn't been updated for awhile. https://communitysolidserver.github.io/css-helm-chart/ -> this repo uses the `index.yaml` in the root of https://github.com/CommunitySolidServer/css-helm-chart/tree/gh-pages/, which seems to get updated on a regular basis to point to the new github releases.
|
So, your chart linting uses the whole directory, meaning it's telling me I should bump the version for an identical chart, because the README changed. To fix this, the chart linter should probably only be linting the chart folder, and the README itself should probably be in the root of the repo, rather than the chart folder. |
|
Thanks for the fix, changing the github repo location + move from GH pages on main to on branch seems to have broken those links indeed. The readme is an integral part of the chart version though, as it is packaged together and the Readme is actually used in places like artifactHub, see https://artifacthub.io/packages/helm/community-solid-server/community-solid-server So either we disable the version check altogether on ct lint or we bump a patch version for the Readme changes. I would propose we merge the changes of this PR and #15 into one version bump. I will have some time later this week to work on the TLS setup. |
https://communitysolidserver.github.io/css-helm-chart/charts/ -> this repo leads to a (very) outdated helm repo, served from this folder: https://github.com/CommunitySolidServer/css-helm-chart/tree/gh-pages/charts/. The
index.yamlfile in that folder hasn't been updated for awhile.https://communitysolidserver.github.io/css-helm-chart/ -> this repo uses the
index.yamlin the root of https://github.com/CommunitySolidServer/css-helm-chart/tree/gh-pages/, which seems to get updated on a regular basis to point to the new github releases.