Revert to using https when generating a baseUrl#15
Revert to using https when generating a baseUrl#15ianconsolata wants to merge 1 commit intoCommunitySolidServer:mainfrom
Conversation
`https` is a more secure default than `http`. Additionally, the previous helper file created `https` baseUrls, so upgrading to the new chart version will cause the base URL of the server to change if folks don't have `baseUrlOverride` set.
|
Not sure what version to use here. This is technically a breaking change, but only because it's fixing an issue with a previous change that was probably unintentional. Here's the commit that changed it: It seems like perhaps it should only be |
|
The http/https setup is on my own todo list, atm clusters I use actually all have TLS termination at the proxy level so its a different setup (just needs https in base URL but no need for cert/key/tls secret). Didn't want https to be the default since it's not default for CSS itself atm, and setup of https varies depending on config, but we should definitely push to make this the default. Having plain http and no ingress can be used when all communication is kept inside the cluster, to develop some internal application. tls:
enabled: false
autoGenerated: true
existingSecret: ""
caCert: "" #base64 encoded
caKey: "" #base64 encodedPerhaps we could enable it by default and use self signed certificates that get auto generated when key and cert aren't specified? Added option in my example. |
httpsis a more secure default thanhttp. Additionally, the previous helper file createdhttpsbaseUrls, so upgrading to the new chart version will cause the base URL of the server to change if folks don't havebaseUrlOverrideset.