Sample improvements #356
Sample improvements #356
Conversation
|
@niels9001 one thing with something like the CanvasLayout sample is that it also needs Horizontal scrolling...
So how should we handle this case? |
Oh, I'd be expecting the horizontal scrollbar to show up here (since it works for thr vertical by default as well)? I will have a look! |
niels9001
force-pushed
the
user/niels9001/sample-fixes
branch
2 times, most recently
from
6d5d328 to
43e0d8a
Compare
|
Filed CommunityToolkit/Tooling-Windows-Submodule#74 for tracking the horizontal scrolling issue, so we can just merge this and move forward and get this in before we split everything out. @niels9001 can you resolve the merge conflict and ensure the XAML Styler check works so we can get a clean build? Thanks! |
michael-hawker
force-pushed
the
user/niels9001/sample-fixes
branch
from
8ef4660 to
0d18b44
Compare
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Tested UWP/WASDK/WASM locally, all looks good still.
* CanvasLayout * CanvasView * RivePlayer * SettingsControls * SizerBase * Template * Update ToolkitSampleRenderer.xaml * Fix CI * Tweaks * CI * Updating markdown files * XAML styler * CanvasLayout * CanvasView * Template * Tweaks * CI * Updating markdown files * Remove MinWidth
2 participants
Cleaning up the existing samples (e.g. improving colors, removing unnecessary scrollviewers).
Project template looked good, no changes needed there?