Move project template from /template/ProjectTemplate to /common/ProjectTemplate #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hawker
force-pushed
the
llama/move-template
branch
from
6c4fd4f to
3b8c9bf
Compare
Member
Author
|
Merged #356 and rebased this PR. Had a clean build before, so should be all set to go. Tested template locally, and we have the CI step for that too, so we should be all good. @Arlodotexe any feedback or concerns? Think we'll be ready to go with this! 🎉🎉🎉 |
This was referenced Mar 13, 2023
Arlodotexe
approved these changes
Mar 13, 2023
Member
Arlodotexe
left a comment
Arlodotexe
left a comment
There was a problem hiding this comment.
Fully tested on my local machine. Lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
Should rebase and wait until #356 is merged.
This just moves the
ProjectTemplatefolder into thecommonfolder (goes well next toProjectHeadsanyway).Had to update a couple of paths, but not many, hopefully everything should still just work, CI should be a telling factor.
We discussed renaming the
commonfolder totooling, think will do that as a follow-on PR?Readme location moved, but was already excluded in template config, so should be good there.