Skip to content

Stop using deprecated set-output in GitHub Actions#10588

Merged
vojtapolasek merged 1 commit intoComplianceAsCode:masterfrom
Mab879:fix_save_set_state
May 19, 2023
Merged

Stop using deprecated set-output in GitHub Actions#10588
vojtapolasek merged 1 commit intoComplianceAsCode:masterfrom
Mab879:fix_save_set_state

Conversation

@Mab879
Copy link
Copy Markdown
Member

@Mab879 Mab879 commented May 18, 2023

Description:

This PR removes the usage set-output in our actions, plus a temporary commit to modify the content to trigger the CI.

Rationale:

Our actions will start to fail on 1 June 2023.

See GitHub's blog.

Review Hints:

Please leave a comment before merging as I pull the content modification commit before this is merged to master.

@Mab879 Mab879 added the Infrastructure Our content build system label May 18, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone May 18, 2023
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label May 18, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Mab879 Mab879 marked this pull request as ready for review May 18, 2023 20:38
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label May 18, 2023
@github-actions
Copy link
Copy Markdown

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 force-pushed the fix_save_set_state branch 2 times, most recently from f1f3d96 to 16e0f4d Compare May 18, 2023 20:50
Per GitHub's blog post
(https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)

The `set-output` command will start to fail on June 1, 2023.
@Mab879 Mab879 force-pushed the fix_save_set_state branch from 16e0f4d to 7d43e11 Compare May 18, 2023 20:54
@vojtapolasek vojtapolasek self-assigned this May 19, 2023
Copy link
Copy Markdown
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mab879 thank you for the fix and for noticing this. I went through all workflow files and no instance of set-output is left.
I will merge it after you remove the triggering commit.

@ggbecker ggbecker changed the title Stop using deperated set-output in GitHub Actions Stop using deprecated set-output in GitHub Actions May 19, 2023
@Mab879 Mab879 force-pushed the fix_save_set_state branch from 7d43e11 to 98f9ff9 Compare May 19, 2023 13:01
@Mab879
Copy link
Copy Markdown
Member Author

Mab879 commented May 19, 2023

@Mab879 thank you for the fix and for noticing this. I went through all workflow files and no instance of set-output is left. I will merge it after you remove the triggering commit.

The commit has been pulled.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 98f9ff9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek merged commit 2e5d857 into ComplianceAsCode:master May 19, 2023
@Mab879 Mab879 deleted the fix_save_set_state branch May 19, 2023 14:59
@Biehlj
Copy link
Copy Markdown

Biehlj commented Sep 11, 2023

resolves #9679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Our content build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants