Fix compare datastream check to correctly treat new line characters.#10667
Merged
Mab879 merged 1 commit intoComplianceAsCode:masterfrom Jun 1, 2023
Merged
Fix compare datastream check to correctly treat new line characters.#10667Mab879 merged 1 commit intoComplianceAsCode:masterfrom
Mab879 merged 1 commit intoComplianceAsCode:masterfrom
Conversation
edf7e75 to
5f7b0d8
Compare
Member
Author
|
@Mab879 This is one of the cases that we will have to merge it first in order to understand if it works because of: which allows posting comment but only runs what is already merged. I'll see if I can test on my fork first. |
Member
Author
|
This seems to fix the problem as tested in this PR: |
5f7b0d8 to
99d2342
Compare
99d2342 to
5cbbf3c
Compare
|
Code Climate has analyzed commit 5cbbf3c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.8% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try a fix for the following:
This datastream diff is auto generated by the check
Compare DS/Generate DiffClick here to see the full diff
The break line characters were necessary before: #10588
Implementation according: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-of-a-multiline-string