Fix coreos_kernel_option oval check#6133
Closed
JAORMX wants to merge 1 commit intoComplianceAsCode:masterfrom
Closed
Fix coreos_kernel_option oval check#6133JAORMX wants to merge 1 commit intoComplianceAsCode:masterfrom
JAORMX wants to merge 1 commit intoComplianceAsCode:masterfrom
Conversation
The regex was missing a `.`
Contributor
Author
|
Pull-request updated, HEAD is now 757e53a |
matejak
reviewed
Sep 30, 2020
| <title>Ensure that the most recent (default) CoreOS boot loader entry is configured to run Linux operating system with argument {{{ ARG_NAME_VALUE }}}</title> | ||
| {{{- oval_affected(products) }}} | ||
| <description>Ensure {{{ ARG_NAME_VALUE }}} option is configured in the 'options' line in /boot/loader/entries/ostree-2-*.conf (or ostree-1-*.conf if the second version does not exists).</description> | ||
| <description>Ensure {{{ ARG_NAME_VALUE }}} option is configured in the 'options' line in /boot/loader/entries/ostree-2-.*.conf (or ostree-1-.*.conf if the second version does not exists).</description> |
Member
There was a problem hiding this comment.
Could you consider getting rid of this metadata boilerplate similarly to e.g. https://github.com/ComplianceAsCode/content/blob/master/shared/templates/template_OVAL_file_owner i.e. by using the oval_metadata macro? That would look like {{{ oval_metadata("Ensure " + ARG_NAME_VALUE + " option is configured in the 'options' line in /boot/loader/entries/ostree-2-.*.conf (or ostree-1-.*.conf if the second version does not exist).") }}}
Member
|
@openscap-ci test this please |
Member
|
I'm reworking these rules and templates in #6100. I'll incorporate this fix. I'll also consider using |
Contributor
Author
|
Abandoning in favor of #6100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex was missing a
.