Skip to content

Colorful buttons#31

Merged
mxmeinhold merged 4 commits intodevelopfrom
colorful-buttons
Apr 10, 2021
Merged

Colorful buttons#31
mxmeinhold merged 4 commits intodevelopfrom
colorful-buttons

Conversation

@WillNilges
Copy link
Copy Markdown
Member

Closes #17

Volting buttons now change color depending on what kind of vote is happening. They are also now center-justified, improving the look-and-feel of the voting screen.

Do not merge until docker is merged.

Comment thread client/.env Outdated
Comment thread client/src/components/NavBar/NavBar.tsx Outdated
Comment thread client/src/components/Pages/Result/index.tsx Outdated
@WillNilges WillNilges marked this pull request as ready for review November 4, 2020 05:28
@WillNilges WillNilges marked this pull request as draft November 4, 2020 05:28
@WillNilges WillNilges marked this pull request as ready for review November 9, 2020 18:02
@mxmeinhold mxmeinhold changed the base branch from develop to docker November 9, 2020 18:11
@mxmeinhold mxmeinhold changed the base branch from docker to develop November 9, 2020 18:11
Copy link
Copy Markdown
Contributor

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get linting into develop and rebase this on the lint fixes before we do this. I can throw lint commits to develop later and toss you some patches or a script when I finish homework, so either tonight or.... next Saturday.

Comment thread client/.env Outdated
Comment thread client/src/components/Pages/Vote/index.tsx Outdated
@WillNilges
Copy link
Copy Markdown
Member Author

LGTM

@mxmeinhold mxmeinhold merged commit 723f54f into develop Apr 10, 2021
@mxmeinhold mxmeinhold deleted the colorful-buttons branch April 10, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Colorful Buttons for vote options

3 participants