Skip to content

Linting and github actions#34

Merged
mxmeinhold merged 6 commits intodevelopfrom
linting
Feb 4, 2021
Merged

Linting and github actions#34
mxmeinhold merged 6 commits intodevelopfrom
linting

Conversation

@mxmeinhold
Copy link
Copy Markdown
Contributor

@mxmeinhold mxmeinhold commented Jan 30, 2021

Here are the linting changes I said I'd do in November for #31 and a bit more.

After this gets merged, @WillNilges I rebased 31 on the linting fixes. The rebased commits are available on the branch 31-linted.

Use NODE_ENV to pick which collections to access, to separate dev and
prod.
Stub types package was causing tsc conflicts
Add to the service tsconfig to make it build
Copy link
Copy Markdown
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, dawg.

:shipit:

@mxmeinhold mxmeinhold merged commit 85f5e89 into develop Feb 4, 2021
@mxmeinhold mxmeinhold deleted the linting branch February 4, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants