Version 2.1.0#52
Merged
mxmeinhold merged 8 commits intomasterfrom Sep 19, 2019
Merged
Conversation
* Add support for serving from a local path and with no ldap * add s3 uri config * more s3 fixes * force imageio to version 2.4.0 to avoid deprecation issues * fix typo * set the correct signature version * use proper secret id in s3 file store * hopefully final fix of the s3 api commands
* Initial file hiding and lockdown schema * Adding migration for model * Functioning lockdown and file hide * Fixing nav icon * Changing wording of alerts
devinmatte
requested review from
RamZallan,
liam-middlebrook,
mxmeinhold and
sauriol
mxmeinhold
approved these changes
Sep 18, 2019
Contributor
mxmeinhold
left a comment
mxmeinhold
left a comment
There was a problem hiding this comment.
Alrighty, I think this is good to go. Nothing stands out.
At the very least #yolo-ops, it works in dev.
@RamZallan Do have a chance to glance at this? Otherwise I think it's good and would like to toss this up tonight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update will allow for a basic hide/show featureset and a lockdown feature. This is needed to get Gallery back up for the masses