Remove hidden files from directory thumbnails#56
Merged
RamZallan merged 5 commits intoComputerScienceHouse:developfrom Oct 8, 2019
Merged
Remove hidden files from directory thumbnails#56RamZallan merged 5 commits intoComputerScienceHouse:developfrom
RamZallan merged 5 commits intoComputerScienceHouse:developfrom
Conversation
mxmeinhold
reviewed
Oct 2, 2019
| for d in Directory.query.filter(Directory.thumbnail_uuid == file_model.thumbnail_uuid).all(): | ||
| d.thumbnail_uuid = DEFAULT_THUMBNAIL_NAME | ||
|
|
||
| refresh_thumbnail() |
Contributor
There was a problem hiding this comment.
@RamZallan do thumbnails get refreshed periodically or does it need to be explicitly done this way every time?
Member
There was a problem hiding this comment.
AFAIK we don't regularly refresh the thumbnail, though there is a CLI command exposed here.
Contributor
There was a problem hiding this comment.
Then I guess this does need to be run every time, unless we want to set up some timed job to do this.
Member
|
@owencmiller have you gotten a chance to test this locally? |
Contributor
Author
|
@RamZallan tested locally and working 👍 |
RamZallan
approved these changes
Oct 8, 2019
Member
RamZallan
left a comment
RamZallan
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating the README with local instructions!
RamZallan
added a commit
that referenced
this pull request
Oct 10, 2019
* Added mp3 support * Added wav support, added default thumbnail * Remove hidden files from directory thumbnails (#56) * Remove hidden file from directory thumbnails * Fix typo * Fix show button * Update README with local dev instructions * Fix directory thumbnails showing hidden files * Various lockdown fixes (#58) * Add .swp files to gitignore * Display more helpful lockdown page, move more routes behind lockdown * Version bump * Remove old password from localconfig * Update local development instructions and gitignore
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents hidden files from appearing as directory thumbnails.