Conversation
mxmeinhold
approved these changes
Oct 8, 2019
Contributor
mxmeinhold
left a comment
mxmeinhold
left a comment
There was a problem hiding this comment.
We could probably wrap this into a decorator to make it less repetitive, but if you're happy with it LGTM.
🚢 🙌
Member
Author
|
I figured that was a bit broader scope, maybe tying it into the existing |
Contributor
|
Sounds good to me. |
RamZallan
added a commit
that referenced
this pull request
Oct 10, 2019
* Added mp3 support * Added wav support, added default thumbnail * Remove hidden files from directory thumbnails (#56) * Remove hidden file from directory thumbnails * Fix typo * Fix show button * Update README with local dev instructions * Fix directory thumbnails showing hidden files * Various lockdown fixes (#58) * Add .swp files to gitignore * Display more helpful lockdown page, move more routes behind lockdown * Version bump * Remove old password from localconfig * Update local development instructions and gitignore
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.
Adds lockdown to various missed routes (most of the file/dir APIs, allowing someone to avoid the lockdown if they know a file/dir's id, as well as the dir tree and random file pages)
Displays a better page when on lockdown, to minimize people thinking they're hitting an error: