Conversation
Merge old thumbnail rotation fix with current develop branch
Add local dev environment threading issue solution to README
Fix Gallery Organizers Fix Finalized Organizer Remove Files Re-add things I touched from dev Add to sample, fix spelling
Gallery Organizers
See liam-middlebrook/csh_ldap#33
Dockerfile: pin to buster image
Contributor
|
On my local dev, everything worked how I intended. I have not been able to test it with the actual LDAP because someone needs to be given the role who is trusted. |
Member
Author
(We verified it works) |
Member
|
LGTM in general, but FYI that we generally bumped the version when merging to master, i.e. #59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping for some feedback from @jabbate19 and @geoffmoss0 just to make sure their changes are okay to put in prod!