Skip to content

Conversation

@shivangvijay
Copy link
Contributor

@shivangvijay shivangvijay commented Jan 7, 2023

The cause of issue#25 is in the "which open" command. As per my knowledge and research, there is no "open" command in Linux; instead, Linux uses xdg-open. But in my Linux OS, the command "which open" returns 0 as it gets some path( see attached image).

Screenshot from 2023-01-07 17-04-01

And "open -a https://controlcore-project.github.io/concore-editor/" and "open https://controlcore-project.github.io/concore-editor/" commands are not working in Linux (see attached image).

Screenshot from 2023-01-07 18-08-15

So, in my implementation, I put OS checks. I think it is a better way than the "which" command.

if [ $? == 0 ]
then
open https://controlcore-project.github.io/DHGWorkflow/
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your attempt at fixing this issue.

A few pointers:

  1. When you make a fix to a bug, always make sure to do the minimal needed changes. So in this case, changing the URL was all you had to do. Other changes are irrelevant.
  2. I have fixed these in the recent commits.
  3. However, the actual reason for these bugs is due to the dev branch being stale. I am attempting to merge the main branch back into the dev. But it has some merge conflicts. So I will come back to that later. merge back to dev #28

In the meantime, please work on the main branch unless we explicitly ask you to work on the dev branch.

I close this pull request now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pradeeban for your pointers. I'll consider your points.

But I working on main branch only, this issue occur in main branch as well as in dev branch. I put pull requests in dev branch because in the documentation you mentioned "Please make sure to send your concore pull requests to the dev branch."

Let me tell you the problem in detail. Please follow my screenshots that I attached in pull requests.

Copy link
Member

@pradeeban pradeeban Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shivangvijay, thanks for the explanation. That makes sense.

The dev branch had become stale (because we were committing changes to the main branch and dev branch simultaneously), and any commits to that were deviating from the main. Now I have merged #28. So now you should be able to create pull requests to the dev branch, as you pointed out from the README.

We were testing on Windows and Mac and apparently did not realize the issue you pointed out. Now I have adopted your changes and committed it. Please see the updates in the relevant bug report #25.

@pradeeban pradeeban closed this Jan 8, 2023
@pradeeban pradeeban reopened this Jan 11, 2023
@pradeeban pradeeban closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants