Skip to content

Resolve issue of not working edit graph. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shivangvijay wants to merge 1 commit into from
Closed

Resolve issue of not working edit graph. #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions editgraph
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
#!/bin/bash
which open
if [ $? == 0 ]
then
open https://controlcore-project.github.io/DHGWorkflow/
else
Copy link
Member

@pradeeban pradeeban Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your attempt at fixing this issue.

A few pointers:

  1. When you make a fix to a bug, always make sure to do the minimal needed changes. So in this case, changing the URL was all you had to do. Other changes are irrelevant.
  2. I have fixed these in the recent commits.
  3. However, the actual reason for these bugs is due to the dev branch being stale. I am attempting to merge the main branch back into the dev. But it has some merge conflicts. So I will come back to that later. merge back to dev #28

In the meantime, please work on the main branch unless we explicitly ask you to work on the dev branch.

I close this pull request now.

Copy link
Contributor Author

@shivangvijay shivangvijay Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pradeeban for your pointers. I'll consider your points.

But I working on main branch only, this issue occur in main branch as well as in dev branch. I put pull requests in dev branch because in the documentation you mentioned "Please make sure to send your concore pull requests to the dev branch."

Let me tell you the problem in detail. Please follow my screenshots that I attached in pull requests.

Copy link
Member

@pradeeban pradeeban Jan 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shivangvijay, thanks for the explanation. That makes sense.

The dev branch had become stale (because we were committing changes to the main branch and dev branch simultaneously), and any commits to that were deviating from the main. Now I have merged #28. So now you should be able to create pull requests to the dev branch, as you pointed out from the README.

We were testing on Windows and Mac and apparently did not realize the issue you pointed out. Now I have adopted your changes and committed it. Please see the updates in the relevant bug report #25.

which xdg-open
if [ $? == 0 ]
then
xdg-open https://controlcore-project.github.io/DHGWorkflow/
else
echo "unable to open browser for DHGWorkflow"
fi

if [[ "$OSTYPE" =~ ^darwin ]]; then
open -a 'Google Chrome' https://controlcore-project.github.io/concore-editor/
fi

if [[ "$OSTYPE" =~ ^linux ]]; then
xdg-open https://controlcore-project.github.io/concore-editor/
fi