Skip to content

Comments

Make Catalog Clean Up#435

Merged
martinkilbinger merged 9 commits intoCosmoStat:developfrom
sfarrens:make_catalog_cleanup
Sep 10, 2021
Merged

Make Catalog Clean Up#435
martinkilbinger merged 9 commits intoCosmoStat:developfrom
sfarrens:make_catalog_cleanup

Conversation

@sfarrens
Copy link
Member

@sfarrens sfarrens commented Jul 29, 2021

Closes #420

@sfarrens sfarrens added this to the First Code Clean Up milestone Jul 29, 2021
@sfarrens sfarrens self-assigned this Jul 29, 2021
@sfarrens sfarrens linked an issue Jul 29, 2021 that may be closed by this pull request
[Management] Module clean up: make_catalog_runner #420
Closed
@sfarrens sfarrens changed the title cleaned up make catalog module Make Catalog Clean Up Jul 29, 2021
@sfarrens sfarrens mentioned this pull request Jul 29, 2021
Closed
13 tasks
@sfarrens
Copy link
Member Author

sfarrens commented Jul 30, 2021

@martinkilbinger I think this is ready to be checked now. I did my best to refactor things to make it a bit easier to maintain but it's still not very "clean" in my opinion. I will run some tests early next week to make sure it works.

@sfarrens
Copy link
Member Author

sfarrens commented Sep 10, 2021

@martinkilbinger I actually found some issues with this PR that I am fixing now, so may need to check it again when I am finished. 🙂

@sfarrens
Copy link
Member Author

sfarrens commented Sep 10, 2021

@martinkilbinger I have finished running tests and the current version of this module should now produce consistent results to the previous version. Note that the output FITS file does not have all the column in the same order as before, but all the numerical values in each column are the same and all the same columns are present.

This module is still a bit messy in my opinion and could be further improved, but I think we can merge this version now (unless you notice any other issues) and we can open another issue to further improve it down the road.

@martinkilbinger martinkilbinger merged commit 9ddc708 into CosmoStat:develop Sep 10, 2021
@martinkilbinger martinkilbinger deleted the make_catalog_cleanup branch September 10, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinkilbinger martinkilbinger martinkilbinger approved these changes

Assignees

@sfarrens sfarrens

Labels

clean up

Projects

None yet

Milestone

First Code Clean Up

Development

Successfully merging this pull request may close these issues.

[Management] Module clean up: make_catalog_runner

2 participants

@sfarrens @martinkilbinger