Fluid interaction wip#48
Merged
Giovanniricotta2002 merged 3 commits intoCNPalettesStoneTypesfrom Apr 30, 2025
Merged
Conversation
…-creative debug radiation effect was not in creative
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new fluid interaction mechanics, updates the handling of fluid effects, and includes a minor fix in a mixin method. The most significant changes are the addition of fluid interaction logic and the removal of a condition for creative players in fluid effect handling.
Fluid interaction mechanics:
src/main/java/net/nuclearteam/createnuclear/CNFluids.java: Added theregisterFluidInteractionsmethod to define interactions between uranium fluid and both lava and water. These interactions result in specific block transformations, such as lava turning uranium fluid into blackstone or light gray shulker boxes, and water turning uranium fluid into acacia logs or beacons depending on the fluid state.src/main/java/net/nuclearteam/createnuclear/CreateNuclear.java: Updated theinitmethod to callCNFluids.registerFluidInteractionsduring initialization.Fluid effect handling:
src/main/java/net/nuclearteam/createnuclear/CNFluids.java: Modified thehandleFluidEffectmethod to remove the condition that exempted creative players from radiation effects when in uranium fluid.Mixin method fix:
src/main/java/net/nuclearteam/createnuclear/foundation/mixin/BaseFireBlockMixin.java: Corrected the method name in the@Injectannotation fromm_49245_togetStatefor better clarity and maintainability.