Adjustments to style of select tags and plan download layout #3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
johnpinto1
force-pushed
the
gjacob24-contribution-of-style-of-select-tags-and-plan-download-layout
branch
from
56b07ea to
c8742a6
Compare
aaronskiba
reviewed
Apr 24, 2025
Contributor
aaronskiba
left a comment
aaronskiba
left a comment
There was a problem hiding this comment.
I'm liking all of the form-control to form-select updates here, and I may have found some additional needed ones as well. I've created PR #3517 which is pointed at this current PR. Please let me know what you think, thanks. :)
Contributor
Thanks @aaronskiba! We noticed that there may be a few more missing. So, will add to your PR next week if you haven't already covered it :) |
johnpinto1
force-pushed
the
gjacob24-contribution-of-style-of-select-tags-and-plan-download-layout
branch
2 times, most recently
from
c1ce784 to
1635e58
Compare
Contributed by @gjacob24 of DCC DMPonline. The changes: - Replaced Selection_tag classes incorrectly set with 'form-control' to 'form-select'. Co-authored-by: gjacob24 <gjacob@ed.ac.uk>
Contributed by @gjacob24 of DCC DMPonline. Changes: - Adjusts the layout and displays the 'optional plan components' and 'select phase to download' side by side for multi-phase plans. Co-authored-by: gjacob24 <gjacob@ed.ac.uk>
johnpinto1
force-pushed
the
gjacob24-contribution-of-style-of-select-tags-and-plan-download-layout
branch
from
1635e58 to
36ba6aa
Compare
- This changes expand upon commit 87ddbb0
- This change improves the styling/positioning between the "Optional plan components" and "Select phase to download" headings.
- Added "form-control" class to "Optional plan components" heading to match "Select phase to download" stylings
- Replaced `<legend>` element with a `label_tag`+ `form-label` class to again improve consistency between the two headings.
- Note, the added `label_tag` doesn't associate with any specific form control, so the first paramater is left empty.
…of-style-of-select-tags-and-plan-download-layout Additional `form-control` to `form-select` changes & styling changes to "Download settings" subheadings
…ect-tags-and-plan-download-layout
- Commit 72c2519 improved the alignment between the 'Optional plan components' and 'Select phase to download' headings. However, the change from <legend> to an unreferenced label_tag() hurt the accessibility. - This change puts back the <legend> tag and uses class: 'col-form-label' for both of the aforementioned headings to maintain stylistic consistency between the two elements. - `.col-form-label` overrides <legend> styling to maintain consistent alignment with <label> elements. - Accessibility snapshot of <fieldset> before this fix: Name: "" aria-labelledby: Not specified aria-label: Not specified From legend: Not specified title: Not specified Role: group Invalid user entry: false - Accessibility snapshot of <fieldset> after this fix: Name: "Optional Plan Components" aria-labelledby: Not specified aria-label: Not specified From legend: legend.col-form-label "Optional Plan Components" title: Not specified Role: group Invalid user entry: false Labeled by: legend.col-form-label
aaronskiba
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributed by @gjacob24 of DCC DMPonline.
Code pushed by @johnpinto1 for DCC DMPonline.
Changes:
Before Change:
With Change