Additional form-control to form-select changes & styling changes to "Download settings" subheadings
#3517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
aaronskiba
changed the title
form-control to form-select changesform-control to form-select changes & styling changes to "Download settings" subheadings
johnpinto1
force-pushed
the
gjacob24-contribution-of-style-of-select-tags-and-plan-download-layout
branch
3 times, most recently
from
1635e58 to
36ba6aa
Compare
- This changes expand upon commit 87ddbb0
- This change improves the styling/positioning between the "Optional plan components" and "Select phase to download" headings.
- Added "form-control" class to "Optional plan components" heading to match "Select phase to download" stylings
- Replaced `<legend>` element with a `label_tag`+ `form-label` class to again improve consistency between the two headings.
- Note, the added `label_tag` doesn't associate with any specific form control, so the first paramater is left empty.
aaronskiba
force-pushed
the
aaron/gjacob24-contribution-of-style-of-select-tags-and-plan-download-layout
branch
from
225b93b to
72c2519
Compare
johnpinto1
approved these changes
May 1, 2025
Contributor
johnpinto1
left a comment
johnpinto1
left a comment
There was a problem hiding this comment.
The changes address many styling issues easily missed.
aaronskiba
merged commit a5fd512
into
gjacob24-contribution-of-style-of-select-tags-and-plan-download-layout
7 of 8 checks passed
aaronskiba
deleted the
aaron/gjacob24-contribution-of-style-of-select-tags-and-plan-download-layout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: