fix: package.json to reduce vulnerabilities (#7) #25
fix: package.json to reduce vulnerabilities (#7) #25Dargon789 merged 17 commits intovercel/react-server-components-cve-vu-7qcqr2from
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-14400636 - https://snyk.io/vuln/SNYK-JS-NEXT-14400644
…5a5475d70a [Snyk] Security upgrade next from 15.3.5 to 15.3.8
…cve-vu-7qcqr2 Fix React Server Components CVE vulnerabilities
…omponents-cve-vu-7qcqr2 Revert 20 vercel/react server components CVE vu 7qcqr2
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-14173355 Co-authored-by: snyk-bot <snyk-bot@snyk.io>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-14400636 - https://snyk.io/vuln/SNYK-JS-NEXT-14400644 Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-PLAYWRIGHT-14888269 Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
Bumps [next](https://github.com/vercel/next.js) from 15.3.5 to 15.5.9. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.3.5...v15.5.9) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Bumps [next-auth](https://github.com/nextauthjs/next-auth) from 5.0.0-beta.29 to 5.0.0-beta.30. - [Release notes](https://github.com/nextauthjs/next-auth/releases) - [Commits](https://github.com/nextauthjs/next-auth/compare/next-auth@5.0.0-beta.29...next-auth@5.0.0-beta.30) --- updated-dependencies: - dependency-name: next-auth dependency-version: 5.0.0-beta.30 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-14173355 Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com> Co-authored-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Snyk has created this PR to upgrade react from 19.1.0 to 19.2.0. See this package in npm: react See this project in Snyk: https://app.snyk.io/org/dargon789/project/bd915cfa-8fe9-4f58-ba9a-619316bbc691?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
Snyk has created this PR to upgrade typescript from 5.8.3 to 5.9.3. See this package in npm: typescript See this project in Snyk: https://app.snyk.io/org/dargon789/project/bd915cfa-8fe9-4f58-ba9a-619316bbc691?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
Snyk has created this PR to upgrade zod from 3.25.76 to 4.1.11. See this package in npm: zod See this project in Snyk: https://app.snyk.io/org/dargon789/project/bd915cfa-8fe9-4f58-ba9a-619316bbc691?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
Snyk has created this PR to upgrade next from 15.3.5 to 15.5.4. See this package in npm: next See this project in Snyk: https://app.snyk.io/org/dargon789/project/bd915cfa-8fe9-4f58-ba9a-619316bbc691?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com> Co-authored-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…ates (#8) Bumps the dependencies-major group with 2 updates in the / directory: [next](https://github.com/vercel/next.js) and [zod](https://github.com/colinhacks/zod). Updates `next` from 15.3.5 to 16.0.0 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.3.5...v16.0.0) Updates `zod` from 3.25.76 to 4.1.12 - [Release notes](https://github.com/colinhacks/zod/releases) - [Commits](colinhacks/zod@v3.25.76...v4.1.12) --- updated-dependencies: - dependency-name: next dependency-version: 16.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: dependencies-major - dependency-name: zod dependency-version: 4.1.12 dependency-type: direct:production update-type: version-update:semver-major dependency-group: dependencies-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-PLAYWRIGHTCORE-13553173 Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com> Co-authored-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates several core runtime and tooling dependencies (Next.js, React, Zod, Playwright, and TypeScript) to newer patch/minor versions to address known vulnerabilities, with corresponding lockfile updates. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates a range of project dependencies, primarily targeting 'next', 'zod', 'react', 'next-auth', and 'sharp', to mitigate known vulnerabilities and leverage the latest improvements. The updates also reflect a shift in the required Node.js runtime environment and a general cleanup of the dependency graph, ensuring a more secure and modern development setup. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- React was bumped to 19.2.0 but react-dom remains at 19.1.0; consider updating react-dom to the same version to avoid subtle compatibility issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- React was bumped to 19.2.0 but react-dom remains at 19.1.0; consider updating react-dom to the same version to avoid subtle compatibility issues.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
bc72b65
into
vercel/react-server-components-cve-vu-7qcqr2
…cve-vu-7qcqr2 Merge pull request #25 from Dargon789/main
There was a problem hiding this comment.
Code Review
This pull request aims to reduce vulnerabilities by upgrading several dependencies. While the intent is good, there are critical inconsistencies between package.json and package-lock.json. Several dependencies updated in package.json are not reflected in package-lock.json, and vice-versa. Additionally, react and react-dom versions are out of sync. I've provided a suggestion to fix some of the version mismatches in package.json and recommend running npm install to regenerate the lock file and ensure all dependencies are correctly resolved and locked.
| "next-auth": "5.0.0-beta.29", | ||
| "next-themes": "0.4.6", | ||
| "react": "19.1.0", | ||
| "react": "19.2.0", | ||
| "react-dom": "19.1.0", |
There was a problem hiding this comment.
There are some inconsistencies with dependency versions that need to be addressed.
next-authis updated to5.0.0-beta.30inpackage-lock.json, but it's still5.0.0-beta.29here. It should be updated to match.reactis updated to19.2.0, butreact-domis still at19.1.0. It's highly recommended to keepreactandreact-domversions in sync to avoid subtle bugs.
After updating these, please run npm install to ensure package-lock.json is correctly updated and commit the changes. The current package-lock.json is out of sync with package.json for react, @playwright/test, and typescript as well, which will be fixed by regenerating the lock file.
| "next-auth": "5.0.0-beta.29", | |
| "next-themes": "0.4.6", | |
| "react": "19.1.0", | |
| "react": "19.2.0", | |
| "react-dom": "19.1.0", | |
| "next-auth": "5.0.0-beta.30", | |
| "next-themes": "0.4.6", | |
| "react": "19.2.0", | |
| "react-dom": "19.2.0", |
Summary by Sourcery
Enhancements: