Skip to content

Comments

fix ci#32

Merged
Dargon789 merged 7 commits intovercel/react-server-components-cve-vu-7qcqr2from
main
Jan 19, 2026
Merged

fix ci#32
Dargon789 merged 7 commits intovercel/react-server-components-cve-vu-7qcqr2from
main

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jan 19, 2026

Summary by Sourcery

Build:

  • Update CircleCI job Docker image from a floating current tag to the fixed cimg/base:2024.01 tag.

Dargon789 and others added 7 commits January 19, 2026 18:06
…cve-vu-7qcqr2

Merge pull request #25 from Dargon789/main
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
* Create config.yml

d37b38e

* Update .github/config.yml



* Delete .circleci directory

---------

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@vercel
Copy link
Contributor

vercel bot commented Jan 19, 2026

Deployment failed with the following error:

Resource is limited - try again in 22 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/dargon789-forge?upgradeToPro=build-rate-limit

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 19, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins the CircleCI Docker image to a specific cimg/base version for reproducible builds and relocates the CI configuration into the .github directory.

File-Level Changes

Change Details Files
Pin the CircleCI Docker executor image to a fixed cimg/base version for reproducibility.
  • Update the Docker image tag from a moving current tag to the fixed 2024.01 tag in the CircleCI job configuration
  • Clarify the inline comment to recommend pinning to a specific tag for reproducible builds
  • Ensure the workflow job say-hello remains configured in the say-hello-workflow workflow
.circleci/config.yml
.github/config.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Contributor

snyk-io bot commented Jan 19, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with the Continuous Integration (CI) setup by updating the base Docker image used in the CircleCI configuration. The change aims to improve the stability and reproducibility of CI builds by pinning the Docker image to a specific version rather than using a floating tag.

Highlights

  • CI Configuration Update: The CircleCI configuration file (.github/config.yml) has been updated to specify a fixed version for the cimg/base Docker image.
  • Docker Image Pinning: The cimg/base Docker image version has been changed from current to 2024.01 to ensure reproducible builds.
  • File Formatting: A missing newline character at the end of the .github/config.yml file has been added.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Moving the CircleCI config from .circleci/config.yml to .github/config.yml will prevent CircleCI from detecting the pipeline; if the intent is to keep using CircleCI, keep the file under .circleci/.
  • If this repository also uses GitHub Actions, consider separating the CircleCI config and any GitHub-specific config into their respective conventional directories (e.g., .github/workflows/) to avoid confusion about which system is being configured.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Moving the CircleCI config from `.circleci/config.yml` to `.github/config.yml` will prevent CircleCI from detecting the pipeline; if the intent is to keep using CircleCI, keep the file under `.circleci/`.
- If this repository also uses GitHub Actions, consider separating the CircleCI config and any GitHub-specific config into their respective conventional directories (e.g., `.github/workflows/`) to avoid confusion about which system is being configured.

## Individual Comments

### Comment 1
<location> `.github/config.yml:14` </location>
<code_context>
+      # Specify the version you desire here (pin to a specific tag for reproducible builds)
       # See: https://circleci.com/developer/images/image/cimg/base
-      - image: cimg/base:current
+      - image: cimg/base:2024.01

     # Add steps to the job
</code_context>

<issue_to_address>
**issue (bug_risk):** Relocating CircleCI config from `.circleci/config.yml` to `.github/config.yml` may break CircleCI unless there’s an explicit configuration for this path.

CircleCI only loads `.circleci/config.yml` by default; it won’t read `.github/config.yml` unless you’ve explicitly configured that path in CircleCI or have a sync mechanism in place. Also, this file uses CircleCI syntax, so it won’t run as a GitHub Actions workflow. Please either keep (or duplicate) the config under `.circleci/config.yml` or confirm that your CI setup actually reads from `.github/config.yml`.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the CI by pinning the Docker image version for more reproducible builds and ensuring the configuration file ends with a newline. Both are positive changes.

However, there is a critical concern regarding the file's location. The file appears to be a CircleCI configuration, but it is located at .github/config.yml. CircleCI typically looks for its configuration at .circleci/config.yml. Unless your CircleCI project is specifically configured to use this non-standard path, this change will likely cause your CI builds to fail because the configuration file won't be found. Please double-check your CircleCI project settings to confirm that it's pointing to .github/config.yml. If not, the file should be moved to .circleci/config.yml to ensure CircleCI can execute the workflow.

@Dargon789 Dargon789 merged commit 445645b into vercel/react-server-components-cve-vu-7qcqr2 Jan 19, 2026
4 of 8 checks passed
@Dargon789 Dargon789 linked an issue Feb 7, 2026 that may be closed by this pull request
Dargon789 added a commit that referenced this pull request Feb 7, 2026
* #26 #27 #28 (#29)

* Create config.yml

d37b38e

* Update .github/config.yml

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* Delete .circleci directory

---------

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* fix ci (#32)

* Create config.yml

d37b38e

* Update .github/config.yml

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* Delete .circleci directory

* #26 #27 #28 (#29) (#30)

* Create config.yml

d37b38e

* Update .github/config.yml



* Delete .circleci directory

---------

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vc]: #deps: bump next from 15.3.5 to 15.5.9 (#17)

1 participant