[Stateful Encoding] Add service as top level field to logs#474
Open
[Stateful Encoding] Add service as top level field to logs#474
Conversation
TheSafo
changed the title
trazfr
reviewed
Apr 21, 2026
| // status changes per log while other tags remain stable, which would defeat delta encoding. | ||
| DynamicValue status = 6; | ||
|
|
||
| // Service is sent separately becaues sometimes service is a top level field on the log json AND also in ddtags, and sometimes it's just the top level field. |
There was a problem hiding this comment.
Suggested change
| // Service is sent separately becaues sometimes service is a top level field on the log json AND also in ddtags, and sometimes it's just the top level field. | |
| // Service is sent separately because sometimes service is a top level field on the log json AND also in ddtags, and sometimes it's just the top level field. |
trazfr
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to fix a class of mismatches caused by extracting service from
ddtags- sometimes service needs to exist in ddtags and on the top level log json, sometimes its only in the top level json. This enables our protocol to differentiate the two.