Skip to content

[Stateful Encoding] Add service as top level field to logs #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheSafo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Stateful Encoding] Add service as top level field to logs #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions proto/logsstateful/stateful_encoding.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ message Log {
// Log severity level (e.g. "info", "warn", "error"). Sent separately from tags because
// status changes per log while other tags remain stable, which would defeat delta encoding.
DynamicValue status = 6;

// Service is sent separately becaues sometimes service is a top level field on the log json AND also in ddtags, and sometimes it's just the top level field.
Copy link
Copy Markdown

@trazfr trazfr Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Service is sent separately becaues sometimes service is a top level field on the log json AND also in ddtags, and sometimes it's just the top level field.
// Service is sent separately because sometimes service is a top level field on the log json AND also in ddtags, and sometimes it's just the top level field.

DynamicValue service = 7;
}

message StructuredLog {
Expand Down
Loading
Loading