Update scripts and docs to build using Agent5 embedded Python by masci · Pull Request #15 · DataDog/datadog-agent

masci · 2016-07-19T13:12:27Z

Agent6 will be built using the CPython interpreter coming along with the Agent5, that is now a development requirement.
We use pkg-config to handle dependencies and compile and link time.

Notice: we now use our own Init function for the CPython intepreter so that we can set the Py_NoSiteFlag thus simplifying Agent6 packaging.

olivielpeau · 2016-07-20T11:09:00Z

+For the time being, you need to put in the `PYTHONPATH` enviroment variable where is the CPython installation:
+```
+export PYTHONPATH=/opt/datadog-agent/embedded/lib/python2.7/:/opt/datadog-agent/embedded/lib/python2.7/site-packages/:/opt/datadog-agent/embedded/lib/python2.7/lib-dynload/
+```


why not have a rake run command that sets up the PYTHONPATH and executes the agent binary?

Another proposal, to continue using ./bin/agent and keep the Rakefile as clean as possible, (having in mind this is going to disappear as soon as we have omnibus onboard): an helper setting the PATH and executing the agent binary that is deployed in the bin directory, see pkg/collector/check/py/dist/agent

Very good idea, looks great!

Let's update the README accordingly :)

olivielpeau · 2016-07-20T11:26:40Z

Added in a few comments, open for discussion, but apart from that 👍

olivielpeau · 2016-08-16T10:19:03Z

👍

[aggregator] submit_metric

Use device in addition to inode to resolve path

* Add arm64 builds * Update to reflect build matrix

# This is the 1st commit message: Keep our own copy of cacert.pem - Replace omnibus fetch from upstream with that static copy. - Include text in the BUILD file about how we check for new upstream versions. - Add explanation of why we have this. https://datadoghq.atlassian.net/browse/ABLD-169 # This is the commit message #2: just use copy for windows # This is the commit message #3: qmarks # This is the commit message #4: omnibus is to blame # This is the commit message #5: maybe # This is the commit message #6: add back in default version # This is the commit message #7: drop livestream on debug # This is the commit message #8: You're kidding, :live_stream? # This is the commit message #9: srsly # This is the commit message #10: just copy on windows # This is the commit message #11: cwd with copy probably does not work # This is the commit message #12: just give up on pkg_install for certs # This is the commit message #13: drop unneded pkg_install targets # This is the commit message #14: - use cwd to make it a little cleaner - update cert to 2025-09-09 # This is the commit message #15: comma # This is the commit message #16: Revert use of cwd on copy. It doesn't matter if it is ugly or not. We are going to delete it this quarter anyway.

### What does this PR do? Skip the SSH session patcher and add a test to illustrate the current issue. In addition, adds the possibility to check specific fields in the json returned for ssh_session events. ### Motivation The retry mechanism could cause the agent to send no more than one event per minute if an SSH session was not properly resolved. Previously, the event was not sent and the agent would wait one minute before sending it with the `unknown` type. However, this `authtype` would never be resolved because the session was initialized before the agent started processing events. As a result, every subsequent SSH event would wait one minute for nothing, causing a significant delay in agent events, potentially blocking all the other events. ### Describe how you validated your changes Added a test that illustrate the issue : `TestSSHUserSessionBlocking` With this change, the ssh_session event is now sent with `authtype` set to `unknown` and directly sent. Error without commenting the patcher : ``` Error: Received unexpected error: All attempts fail: #1: not found #2: not found #3: not found #4: not found #5: not found #6: not found #7: not found #8: not found #9: not found #10: not found #11: not found #12: not found #13: not found #14: not found #15: not found #16: not found #17: not found #18: not found #19: not found #20: not found #21: not found #22: not found #23: not found #24: not found #25: not found #26: not found #27: not found #28: not found #29: not found #30: not found Test: TestSSHUserSessionBlocking/second_ssh_no_auth ``` Co-authored-by: theo.putegnat <theo.putegnat@datadoghq.com>

Skip the SSH session patcher and add a test to illustrate the current issue. In addition, adds the possibility to check specific fields in the json returned for ssh_session events. ### Motivation The retry mechanism could cause the agent to send no more than one event per minute if an SSH session was not properly resolved. Previously, the event was not sent and the agent would wait one minute before sending it with the `unknown` type. However, this `authtype` would never be resolved because the session was initialized before the agent started processing events. As a result, every subsequent SSH event would wait one minute for nothing, causing a significant delay in agent events, potentially blocking all the other events. ### Describe how you validated your changes Added a test that illustrate the issue : `TestSSHUserSessionBlocking` With this change, the ssh_session event is now sent with `authtype` set to `unknown` and directly sent. Error without commenting the patcher : ``` Error: Received unexpected error: All attempts fail: #1: not found #2: not found #3: not found #4: not found #5: not found #6: not found #7: not found #8: not found #9: not found #10: not found #11: not found #12: not found #13: not found #14: not found #15: not found #16: not found #17: not found #18: not found #19: not found #20: not found #21: not found #22: not found #23: not found #24: not found #25: not found #26: not found #27: not found #28: not found #29: not found #30: not found Test: TestSSHUserSessionBlocking/second_ssh_no_auth ``` Co-authored-by: theo.putegnat <theo.putegnat@datadoghq.com> (cherry picked from commit 40d1f09) ___ Co-authored-by: Théo Putegnat <theo.putegnat@datadoghq.com>

Backport 40d1f09 from #45437. ___ ### What does this PR do? Skip the SSH session patcher and add a test to illustrate the current issue. In addition, adds the possibility to check specific fields in the json returned for ssh_session events. ### Motivation The retry mechanism could cause the agent to send no more than one event per minute if an SSH session was not properly resolved. Previously, the event was not sent and the agent would wait one minute before sending it with the `unknown` type. However, this `authtype` would never be resolved because the session was initialized before the agent started processing events. As a result, every subsequent SSH event would wait one minute for nothing, causing a significant delay in agent events, potentially blocking all the other events. ### Describe how you validated your changes Added a test that illustrate the issue : `TestSSHUserSessionBlocking` With this change, the ssh_session event is now sent with `authtype` set to `unknown` and directly sent. Error without commenting the patcher : ``` Error: Received unexpected error: All attempts fail: #1: not found #2: not found #3: not found #4: not found #5: not found #6: not found #7: not found #8: not found #9: not found #10: not found #11: not found #12: not found #13: not found #14: not found #15: not found #16: not found #17: not found #18: not found #19: not found #20: not found #21: not found #22: not found #23: not found #24: not found #25: not found #26: not found #27: not found #28: not found #29: not found #30: not found Test: TestSSHUserSessionBlocking/second_ssh_no_auth ``` Co-authored-by: axel.vonengel <axel.vonengel@datadoghq.com>

Backport 40d1f09 from #45437. ___ ### What does this PR do? Skip the SSH session patcher and add a test to illustrate the current issue. In addition, adds the possibility to check specific fields in the json returned for ssh_session events. ### Motivation The retry mechanism could cause the agent to send no more than one event per minute if an SSH session was not properly resolved. Previously, the event was not sent and the agent would wait one minute before sending it with the `unknown` type. However, this `authtype` would never be resolved because the session was initialized before the agent started processing events. As a result, every subsequent SSH event would wait one minute for nothing, causing a significant delay in agent events, potentially blocking all the other events. ### Describe how you validated your changes Added a test that illustrate the issue : `TestSSHUserSessionBlocking` With this change, the ssh_session event is now sent with `authtype` set to `unknown` and directly sent. Error without commenting the patcher : ``` Error: Received unexpected error: All attempts fail: #1: not found #2: not found #3: not found #4: not found #5: not found #6: not found #7: not found #8: not found #9: not found #10: not found #11: not found #12: not found #13: not found #14: not found #15: not found #16: not found #17: not found #18: not found #19: not found #20: not found #21: not found #22: not found #23: not found #24: not found #25: not found #26: not found #27: not found #28: not found #29: not found #30: not found Test: TestSSHUserSessionBlocking/second_ssh_no_auth ``` Co-authored-by: YoannGh <yoann.ghigoff@datadoghq.com> Co-authored-by: florent.clarret <florent.clarret@datadoghq.com>

### What does this PR do? Skip the SSH session patcher and add a test to illustrate the current issue. In addition, adds the possibility to check specific fields in the json returned for ssh_session events. ### Motivation The retry mechanism could cause the agent to send no more than one event per minute if an SSH session was not properly resolved. Previously, the event was not sent and the agent would wait one minute before sending it with the `unknown` type. However, this `authtype` would never be resolved because the session was initialized before the agent started processing events. As a result, every subsequent SSH event would wait one minute for nothing, causing a significant delay in agent events, potentially blocking all the other events. ### Describe how you validated your changes Added a test that illustrate the issue : `TestSSHUserSessionBlocking` With this change, the ssh_session event is now sent with `authtype` set to `unknown` and directly sent. Error without commenting the patcher : ``` Error: Received unexpected error: All attempts fail: #1: not found #2: not found #3: not found #4: not found #5: not found #6: not found #7: not found #8: not found #9: not found #10: not found #11: not found #12: not found #13: not found #14: not found #15: not found #16: not found #17: not found #18: not found #19: not found #20: not found #21: not found #22: not found #23: not found #24: not found #25: not found #26: not found #27: not found #28: not found #29: not found #30: not found Test: TestSSHUserSessionBlocking/second_ssh_no_auth ``` Co-authored-by: theo.putegnat <theo.putegnat@datadoghq.com>

masci added the dev/tooling label Jul 19, 2016

masci force-pushed the massi/build-linux branch from bad6874 to 020f231 Compare July 19, 2016 14:19

use pkg-config to support osx and linux builds

aad1171

masci force-pushed the massi/build-linux branch from 020f231 to aad1171 Compare July 20, 2016 08:49

olivielpeau reviewed Jul 20, 2016
View reviewed changes

Massimiliano Pippi added 4 commits July 20, 2016 15:08

removed golint, we need the bin and glide doesn't support it

884f1aa

added binary helper

e3eddd7

Updated test and run informations

6b943b9

fixed path for osx

d3e780a

masci merged commit 976476b into master Aug 16, 2016

masci deleted the massi/build-linux branch August 16, 2016 10:20

olivielpeau mentioned this pull request Jul 18, 2017

[py] Initialize site, and use PYTHONHOME #390

Merged

masci added a commit that referenced this pull request Apr 1, 2019

Merge pull request #15 from DataDog/massi/aggregator

7f9e65f

[aggregator] submit_metric

hush-hush pushed a commit that referenced this pull request Apr 17, 2019

Merge pull request #15 from DataDog/massi/aggregator

71da3ef

[aggregator] submit_metric

safchain added a commit to safchain/datadog-agent that referenced this pull request May 26, 2020

Merge pull request DataDog#15 from lebauce/use-device

fe192fc

Use device in addition to inode to resolve path

karlhenselin mentioned this pull request Feb 7, 2025

[BUG] Deadlock / BLOCKED threads starting tomcat with dd-agent #33821

Closed

s-alad pushed a commit that referenced this pull request Nov 21, 2025

Add arm64 builds (#15)

e79123f

* Add arm64 builds * Update to reflect build matrix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update scripts and docs to build using Agent5 embedded Python#15

Update scripts and docs to build using Agent5 embedded Python#15
masci merged 5 commits intomasterfrom
massi/build-linux

masci commented Jul 19, 2016 •

edited

Loading

Uh oh!

olivielpeau Jul 20, 2016

Uh oh!

masci Jul 20, 2016

Uh oh!

olivielpeau Jul 20, 2016

Uh oh!

olivielpeau commented Jul 20, 2016

Uh oh!

olivielpeau commented Aug 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

masci commented Jul 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olivielpeau Jul 20, 2016

Choose a reason for hiding this comment

Uh oh!

masci Jul 20, 2016

Choose a reason for hiding this comment

Uh oh!

olivielpeau Jul 20, 2016

Choose a reason for hiding this comment

Uh oh!

olivielpeau commented Jul 20, 2016

Uh oh!

olivielpeau commented Aug 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

masci commented Jul 19, 2016 •

edited

Loading