Skip to content

[Backport 7.75.x] [CWS] Skip ssh session patcher#45574

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into7.75.xfrom
backport-45437-to-7.75.x
Jan 28, 2026
Merged

[Backport 7.75.x] [CWS] Skip ssh session patcher#45574
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into7.75.xfrom
backport-45437-to-7.75.x

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts Bot commented Jan 27, 2026

Backport 40d1f09 from #45437.


What does this PR do?

Skip the SSH session patcher and add a test to illustrate the current issue.
In addition, adds the possibility to check specific fields in the json returned for ssh_session events.

Motivation

The retry mechanism could cause the agent to send no more than one event per minute if an SSH session was not properly resolved.
Previously, the event was not sent and the agent would wait one minute before sending it with the unknown type. However, this authtype would never be resolved because the session was initialized before the agent started processing events. As a result, every subsequent SSH event would wait one minute for nothing, causing a significant delay in agent events, potentially blocking all the other events.

Describe how you validated your changes

Added a test that illustrate the issue : TestSSHUserSessionBlocking
With this change, the ssh_session event is now sent with authtype set to unknown and directly sent.

Error without commenting the patcher :

        	Error:      	Received unexpected error:
        	            	All attempts fail:
        	            	#1: not found
        	            	#2: not found
        	            	#3: not found
        	            	#4: not found
        	            	#5: not found
        	            	#6: not found
        	            	#7: not found
        	            	#8: not found
        	            	#9: not found
        	            	#10: not found
        	            	#11: not found
        	            	#12: not found
        	            	#13: not found
        	            	#14: not found
        	            	#15: not found
        	            	#16: not found
        	            	#17: not found
        	            	#18: not found
        	            	#19: not found
        	            	#20: not found
        	            	#21: not found
        	            	#22: not found
        	            	#23: not found
        	            	#24: not found
        	            	#25: not found
        	            	#26: not found
        	            	#27: not found
        	            	#28: not found
        	            	#29: not found
        	            	#30: not found
        	Test:       	TestSSHUserSessionBlocking/second_ssh_no_auth

Skip the SSH session patcher and add a test to illustrate the current issue.
In addition, adds the possibility to check specific fields in the json returned for ssh_session events.

### Motivation

The retry mechanism could cause the agent to send no more than one event per minute if an SSH session was not properly resolved.
Previously, the event was not sent and the agent would wait one minute before sending it with the `unknown` type. However, this `authtype` would never be resolved because the session was initialized before the agent started processing events. As a result, every subsequent SSH event would wait one minute for nothing, causing a significant delay in agent events, potentially blocking all the other events.

### Describe how you validated your changes
Added a test that illustrate the issue : `TestSSHUserSessionBlocking`
With this change, the ssh_session event is now sent with `authtype` set to `unknown` and directly sent.

Error without commenting the patcher :
```
        	Error:      	Received unexpected error:
        	            	All attempts fail:
        	            	#1: not found
        	            	#2: not found
        	            	#3: not found
        	            	#4: not found
        	            	#5: not found
        	            	#6: not found
        	            	#7: not found
        	            	#8: not found
        	            	#9: not found
        	            	#10: not found
        	            	#11: not found
        	            	#12: not found
        	            	#13: not found
        	            	#14: not found
        	            	#15: not found
        	            	#16: not found
        	            	#17: not found
        	            	#18: not found
        	            	#19: not found
        	            	#20: not found
        	            	#21: not found
        	            	#22: not found
        	            	#23: not found
        	            	#24: not found
        	            	#25: not found
        	            	#26: not found
        	            	#27: not found
        	            	#28: not found
        	            	#29: not found
        	            	#30: not found
        	Test:       	TestSSHUserSessionBlocking/second_ssh_no_auth
```

Co-authored-by: theo.putegnat <theo.putegnat@datadoghq.com>
(cherry picked from commit 40d1f09)

___

Co-authored-by: Théo Putegnat <theo.putegnat@datadoghq.com>
@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner January 27, 2026 17:34
@dd-octo-sts dd-octo-sts Bot added backport bot category/bugfix changelog/no-changelog No changelog entry needed component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security labels Jan 27, 2026
@YoannGh YoannGh requested a review from a team as a code owner January 27, 2026 18:07
@YoannGh YoannGh removed the changelog/no-changelog No changelog entry needed label Jan 27, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Jan 27, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8754f93
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 DataNotFound $${708.37}$$ < $${708.6}$$ DataNotFound $${173.95}$$ < $${174.5}$$
agent_deb_amd64_fips DataNotFound $${703.66}$$ < $${703.97}$$ DataNotFound $${172.71}$$ < $${173.77}$$
agent_heroku_amd64 DataNotFound $${328.86}$$ < $${329.53}$$ DataNotFound $${87.45}$$ < $${88.43}$$
agent_msi DataNotFound $${570.99}$$ < $${982.08}$$ DataNotFound $${142.75}$$ < $${143.02}$$
agent_rpm_amd64 DataNotFound $${708.36}$$ < $${708.85}$$ DataNotFound $${176.4}$$ < $${177.66}$$
agent_rpm_amd64_fips DataNotFound $${703.65}$$ < $${703.96}$$ DataNotFound $${175.9}$$ < $${176.63}$$
agent_rpm_arm64 DataNotFound $${689.91}$$ < $${693.49}$$ DataNotFound $${159.95}$$ < $${161.21}$$
agent_rpm_arm64_fips DataNotFound $${686.04}$$ < $${688.44}$$ DataNotFound $${159.42}$$ < $${160.46}$$
agent_suse_amd64 DataNotFound $${708.36}$$ < $${708.85}$$ DataNotFound $${176.4}$$ < $${177.66}$$
agent_suse_amd64_fips DataNotFound $${703.65}$$ < $${703.96}$$ DataNotFound $${175.9}$$ < $${176.63}$$
agent_suse_arm64 DataNotFound $${689.91}$$ < $${693.49}$$ DataNotFound $${159.95}$$ < $${161.21}$$
agent_suse_arm64_fips DataNotFound $${686.04}$$ < $${688.44}$$ DataNotFound $${159.42}$$ < $${160.46}$$
docker_agent_amd64 DataNotFound $${770.15}$$ < $${770.69}$$ DataNotFound $${261.8}$$ < $${262.46}$$
docker_agent_arm64 DataNotFound $${776.27}$$ < $${780.17}$$ DataNotFound $${250.85}$$ < $${252.63}$$
docker_agent_jmx_amd64 DataNotFound $${961.03}$$ < $${961.57}$$ DataNotFound $${330.43}$$ < $${331.09}$$
docker_agent_jmx_arm64 DataNotFound $${955.87}$$ < $${959.77}$$ DataNotFound $${315.47}$$ < $${317.26}$$
docker_cluster_agent_amd64 DataNotFound $${180.7}$$ < $${181.08}$$ DataNotFound $${63.84}$$ < $${64.49}$$
docker_cluster_agent_arm64 DataNotFound $${196.54}$$ < $${198.49}$$ DataNotFound $${60.11}$$ < $${61.17}$$
docker_cws_instrumentation_amd64 DataNotFound $${7.13}$$ < $${7.18}$$ DataNotFound $${2.99}$$ < $${3.33}$$
docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.73}$$ < $${3.09}$$
docker_dogstatsd_amd64 DataNotFound $${38.8}$$ < $${39.38}$$ DataNotFound $${15.02}$$ < $${15.82}$$
docker_dogstatsd_arm64 DataNotFound $${37.13}$$ < $${37.94}$$ DataNotFound $${14.34}$$ < $${14.83}$$
dogstatsd_deb_amd64 DataNotFound $${30.02}$$ < $${30.61}$$ DataNotFound $${7.94}$$ < $${8.79}$$
dogstatsd_deb_arm64 DataNotFound $${28.18}$$ < $${29.11}$$ DataNotFound $${6.82}$$ < $${7.71}$$
dogstatsd_rpm_amd64 DataNotFound $${30.02}$$ < $${30.61}$$ DataNotFound $${7.95}$$ < $${8.8}$$
dogstatsd_suse_amd64 DataNotFound $${30.02}$$ < $${30.61}$$ DataNotFound $${7.95}$$ < $${8.8}$$
iot_agent_deb_amd64 DataNotFound $${42.97}$$ < $${43.29}$$ DataNotFound $${11.25}$$ < $${12.04}$$
iot_agent_deb_arm64 DataNotFound $${40.1}$$ < $${40.92}$$ DataNotFound $${9.62}$$ < $${10.45}$$
iot_agent_deb_armhf DataNotFound $${40.68}$$ < $${41.03}$$ DataNotFound $${9.81}$$ < $${10.62}$$
iot_agent_rpm_amd64 DataNotFound $${42.97}$$ < $${43.29}$$ DataNotFound $${11.26}$$ < $${12.06}$$
iot_agent_suse_amd64 DataNotFound $${42.97}$$ < $${43.29}$$ DataNotFound $${11.26}$$ < $${12.06}$$

@dd-octo-sts dd-octo-sts Bot force-pushed the backport-45437-to-7.75.x branch from 9831025 to acd8515 Compare January 27, 2026 18:16
@dd-octo-sts dd-octo-sts Bot added the changelog/no-changelog No changelog entry needed label Jan 27, 2026
@YoannGh YoannGh force-pushed the backport-45437-to-7.75.x branch from acd8515 to 9831025 Compare January 27, 2026 18:29
Copy link
Copy Markdown
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a minor update requested

Comment thread releasenotes/notes/fix-ssh-retry-delays-dfa36918b20ecbc0.yaml Outdated
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Jan 27, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b888082f-f4bf-44ca-be13-7d2645480e9e

Baseline: 037e9ba
Comparison: 78ea53a
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.57 [-4.51, +1.36] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
ddot_logs memory utilization +0.59 [+0.50, +0.67] 1 Logs
ddot_metrics_sum_delta memory utilization +0.55 [+0.33, +0.76] 1 Logs
otlp_ingest_metrics memory utilization +0.38 [+0.22, +0.54] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.30 [+0.24, +0.35] 1 Logs
quality_gate_logs % cpu utilization +0.13 [-1.34, +1.61] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.07 [-0.16, +0.31] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.38, +0.45] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.03 [-0.13, +0.19] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.41, +0.43] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.14] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.05, +0.05] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.08, +0.07] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.39, +0.36] 1 Logs
otlp_ingest_logs memory utilization -0.08 [-0.17, +0.02] 1 Logs
docker_containers_memory memory utilization -0.09 [-0.16, -0.01] 1 Logs
quality_gate_idle memory utilization -0.11 [-0.16, -0.06] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.19 [-0.42, +0.05] 1 Logs
file_tree memory utilization -0.22 [-0.27, -0.17] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.33 [-0.41, -0.25] 1 Logs
quality_gate_idle_all_features memory utilization -0.52 [-0.55, -0.48] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -1.25 [-1.46, -1.03] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -1.57 [-4.51, +1.36] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@FlorentClarret
Copy link
Copy Markdown
Member

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jan 28, 2026

View all feedbacks in Devflow UI.

2026-01-28 09:06:46 UTC ℹ️ Start processing command /merge


2026-01-28 09:06:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in 7.75.x is approximately 42m (p90).


2026-01-28 09:34:54 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit e062788 into 7.75.x Jan 28, 2026
443 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the backport-45437-to-7.75.x branch January 28, 2026 09:34
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 28, 2026
@github-actions github-actions Bot added this to the 7.75.2 milestone Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport bot category/bugfix changelog/no-changelog No changelog entry needed component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants