Clean unused file, task and module#22067
Conversation
chouetz
added
changelog/no-changelog
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: ea4ff820-2f20-4965-9ffa-5ac4cff35419 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.09 | [-6.46, +6.65] |
| ➖ | idle | memory utilization | -0.23 | [-0.28, -0.19] |
| ➖ | file_tree | memory utilization | -1.96 | [-2.07, -1.86] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +0.58 | [-0.17, +1.32] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.22 | [+0.16, +0.28] |
| ➖ | process_agent_standard_check | memory utilization | +0.10 | [+0.03, +0.17] |
| ➖ | file_to_blackhole | % cpu utilization | +0.09 | [-6.46, +6.65] |
| ➖ | trace_agent_json | ingress throughput | +0.01 | [-0.02, +0.04] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.03, +0.03] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.06, +0.06] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.02 | [-0.04, +0.00] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.19 | [-0.23, -0.16] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.21 | [-0.28, -0.14] |
| ➖ | idle | memory utilization | -0.23 | [-0.28, -0.19] |
| ➖ | file_tree | memory utilization | -1.96 | [-2.07, -1.86] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
chouetz
force-pushed
the
nschweitzer/golang_deps_generate
branch
from
618e52a to
63138ec
Compare
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. There are 4 builds ahead! (estimated merge in less than 1h) you can cancel this operation by commenting your pull request with |
|
merge -c |
dd-devflow
Bot
added
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Remove several exclusion rules that no longer serve any purpose: - `eventContext`, `(*DatadogLogger).changeLogLevel`, `defaultRetryDuration`, `defaultRetries`: suppressed `unused` warnings for symbols that no longer exist in the codebase (or in the case of `changeLogLevel`, the method moved to a different type during a refactor). - `pem.Encode` errcheck exclusion: the file that motivated this (test/integration/utils/certificates.go) was deleted in #39772. All remaining live `pem.Encode` call sites already check or explicitly ignore the error. - `exported const APIName` revive exclusion: the constant no longer exists in `pkg/serverless/trace/inferredspan/`; the file is also already globally excluded via the paths list, making this rule doubly redundant. Also update the stale comment on the `io.WriteString` errcheck exclusion whose originating file (tools/dep_tree_resolver/go_deps.go) was deleted in #22067 — the rule is still live, covering writes to http.ResponseWriter.
### What does this PR do? Removes several dead or redundant exclusion rules from `.golangci.yml`: **Duplicate rule (cosmetic):** - Removed a duplicate `unnecessary conversion` exclusion that appeared twice. **Dead `unused` suppressions (task #10):** - `` `eventContext` is unused `` — symbol no longer exists in the codebase. - `` `(*DatadogLogger).changeLogLevel` is unused `` — `changeLogLevel` moved to `*loggerPointer` during a refactor; the original type no longer has this method. - `` `defaultRetryDuration` is unused `` — symbol no longer exists. - `` `defaultRetries` is unused `` — symbol is used; the linter wouldn't fire on it regardless. **Dead errcheck exclusion:** - `pem.Encode` — the file that motivated this (`test/integration/utils/certificates.go`) was deleted in #39772. All remaining live `pem.Encode` call sites already check or explicitly ignore the error. **Dead revive exclusion:** - `exported const APIName` — the constant no longer exists in `pkg/serverless/trace/inferredspan/`; the file is also already globally excluded via the `paths` list. **Stale comment fix:** - Updated the comment on the `io.WriteString` errcheck exclusion — its originating file (`tools/dep_tree_resolver/go_deps.go`) was deleted in #22067. The rule itself is kept as it still covers unchecked writes to `http.ResponseWriter`. ### Motivation Dead exclusions accumulate noise in the config and make it harder to reason about which rules are actively suppressing real violations. ### Describe how you validated your changes Ran `dda inv linter.go` — 0 issues. ### Additional Notes Part of a broader linter configuration cleanup pass. Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
3 participants
What does this PR do?
Remove a gitlab file containing a job not referenced. Remove the associated task and module
Motivation
Clean-up
Additional Notes
Found no reference of this job being launched, see here
@sgnn7 (edit): Memory is hazy on this since it was a long time ago but I believe that we were generating the artifacts and this script broke when one massive functionality batch got added to the Agent and script started OOMing and breaking as it has a non-linear performance profile. The script then got disabled and never got fixed up due to changing priorities.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.