Remove the `agent_integration_tests` GitLab job as it doesn’t run any useful test anymore by L3n41c · Pull Request #39772 · DataDog/datadog-agent

L3n41c · 2025-08-12T14:42:41Z

What does this PR do?

Remove @DataDog/container-integrations from owner of integration tests found in test/integration and triggered in the agent_integration_tests job.

Motivation

test/integration used to contain CircleCI tests.
@DataDog/container-integrations and @DataDog/container-app have migrated all their tests to the new e2e tests framework so that all their tests have been removed from test/integration with:

Describe how you validated your changes

Wait for CI status…

Possible Drawbacks / Trade-offs

Additional Notes

After this cleanup PR, the only remaining directories inside test/integration are:

test/integration/docker which contains only a single file: otel_agent_build_tests.py and
test/integration/serverless

According to git history, serverless teams seem to be the most active contributors on the remaining tests. Hence the update of the CODEOWNERS files.

agent-platform-auto-pr · 2025-08-12T15:01:08Z

Gitlab CI Configuration Changes

Removed Jobs

agent_integration_tests

Changes Summary

Removed	Modified	Added	Renamed
1	0	0	0

ℹ️ Diff available in the job log.

cit-pr-commenter · 2025-08-12T15:50:54Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 54d81066-980a-4c76-8173-42b53921daee

Baseline: dfca5e3
Comparison: 97677b5
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	docker_containers_cpu	% cpu utilization	+8.96	[+5.76, +12.17]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	docker_containers_cpu	% cpu utilization	+8.96	[+5.76, +12.17]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.76	[+0.36, +1.16]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.66	[+0.53, +0.78]	1	Logs
➖	quality_gate_idle	memory utilization	+0.31	[+0.27, +0.36]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.24	[+0.20, +0.27]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.22	[+0.18, +0.26]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.08	[-0.53, +0.70]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.04	[-0.53, +0.60]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.56, +0.60]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.29, +0.31]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.00	[-2.79, +2.79]	1	Logs bounds checks dashboard
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.03	[-0.65, +0.60]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.14	[-0.21, -0.07]	1	Logs
➖	ddot_metrics	memory utilization	-0.16	[-0.28, -0.05]	1	Logs
➖	file_tree	memory utilization	-0.21	[-0.25, -0.17]	1	Logs
➖	ddot_logs	memory utilization	-0.36	[-0.45, -0.27]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.43	[-0.57, -0.29]	1	Logs
➖	docker_containers_memory	memory utilization	-0.64	[-0.68, -0.59]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

L3n41c · 2025-08-12T15:54:05Z

/merge

dd-devflow-routing-codex · 2025-08-12T15:54:10Z

View all feedbacks in Devflow UI.

2025-08-12 15:54:10 UTC ℹ️ Start processing command /merge

2025-08-12 15:54:31 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-12 19:55:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

agent-platform-auto-pr · 2025-08-12T16:47:56Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor dfca5e3

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${701.4}$$ < $${704.84}$$	$${-0.04}$$	$${177.57}$$ < $${178.58}$$
✅	agent_deb_amd64_fips	$${0}$$	$${699.66}$$ < $${703.09}$$	$${-0.01}$$	$${176.96}$$ < $${178.12}$$
✅	agent_heroku_amd64	$${0}$$	$${351.06}$$ < $${355.37}$$	$${+0.01}$$	$${94.67}$$ < $${95.72}$$
✅	agent_msi	$${0}$$	$${975.56}$$ < $${980.61}$$	$${+0}$$	$${147.45}$$ < $${149.31}$$
✅	agent_rpm_amd64	$${0}$$	$${701.39}$$ < $${704.83}$$	$${+0.02}$$	$${179.84}$$ < $${180.22}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${699.65}$$ < $${703.08}$$	$${-0.03}$$	$${178.84}$$ < $${179.85}$$
✅	agent_rpm_arm64	$${0}$$	$${690.32}$$ < $${694.74}$$	$${-0.02}$$	$${162.13}$$ < $${163.96}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${688.63}$$ < $${693.05}$$	$${+0.01}$$	$${161.14}$$ < $${163.0}$$
✅	agent_suse_amd64	$${0}$$	$${701.39}$$ < $${704.83}$$	$${+0.02}$$	$${179.84}$$ < $${180.22}$$
✅	agent_suse_amd64_fips	$${0}$$	$${699.65}$$ < $${703.08}$$	$${-0.03}$$	$${178.84}$$ < $${179.85}$$
✅	agent_suse_arm64	$${0}$$	$${690.32}$$ < $${694.74}$$	$${-0.02}$$	$${162.13}$$ < $${163.96}$$
✅	agent_suse_arm64_fips	$${0}$$	$${688.63}$$ < $${693.05}$$	$${+0.01}$$	$${161.14}$$ < $${163.0}$$
✅	docker_agent_amd64	$${0}$$	$${783.39}$$ < $${788.65}$$	$${+0}$$	$${269.98}$$ < $${272.01}$$
✅	docker_agent_arm64	$${0}$$	$${795.65}$$ < $${802.0}$$	$${-0}$$	$${256.76}$$ < $${259.7}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${974.69}$$ < $${979.84}$$	$${+0}$$	$${339.03}$$ < $${340.95}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${975.55}$$ < $${981.8}$$	$${-0}$$	$${321.79}$$ < $${324.65}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${214.49}$$ < $${214.5}$$	$${+0}$$	$${72.91}$$ < $${73.51}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${230.32}$$ < $${230.33}$$	$${+0}$$	$${69.16}$$ < $${69.77}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${+0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.71}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.72}$$ < $${39.57}$$	$${-0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${+0}$$	$${37.42}$$ < $${38.2}$$	$${+0}$$	$${14.39}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.95}$$ < $${31.4}$$	$${-0}$$	$${7.89}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.54}$$ < $${29.97}$$	$${-0}$$	$${6.85}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.95}$$ < $${31.4}$$	$${+0}$$	$${7.9}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.95}$$ < $${31.4}$$	$${+0}$$	$${7.9}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${54.36}$$ < $${54.55}$$	$${-0}$$	$${13.68}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${0}$$	$${51.67}$$ < $${51.9}$$	$${+0}$$	$${11.85}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${51.2}$$ < $${51.42}$$	$${-0.03}$$	$${11.92}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${54.36}$$ < $${54.55}$$	$${-0}$$	$${13.7}$$ < $${14.47}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${51.2}$$ < $${51.91}$$	$${-0}$$	$${11.93}$$ < $${12.65}$$
✅	iot_agent_suse_amd64	$${0}$$	$${54.36}$$ < $${54.55}$$	$${-0}$$	$${13.7}$$ < $${14.47}$$

ofek

🥇

L3n41c · 2025-08-13T07:48:57Z

/merge

dd-devflow-routing-codex · 2025-08-13T07:49:01Z

View all feedbacks in Devflow UI.

2025-08-13 07:49:01 UTC ℹ️ Start processing command /merge

2025-08-13 07:49:09 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-13 08:23:06 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 39m (p90).

2025-08-13 08:35:35 UTC ℹ️ MergeQueue: This merge request was merged

Remove several exclusion rules that no longer serve any purpose: - `eventContext`, `(*DatadogLogger).changeLogLevel`, `defaultRetryDuration`, `defaultRetries`: suppressed `unused` warnings for symbols that no longer exist in the codebase (or in the case of `changeLogLevel`, the method moved to a different type during a refactor). - `pem.Encode` errcheck exclusion: the file that motivated this (test/integration/utils/certificates.go) was deleted in #39772. All remaining live `pem.Encode` call sites already check or explicitly ignore the error. - `exported const APIName` revive exclusion: the constant no longer exists in `pkg/serverless/trace/inferredspan/`; the file is also already globally excluded via the paths list, making this rule doubly redundant. Also update the stale comment on the `io.WriteString` errcheck exclusion whose originating file (tools/dep_tree_resolver/go_deps.go) was deleted in #22067 — the rule is still live, covering writes to http.ResponseWriter.

### What does this PR do? Removes several dead or redundant exclusion rules from `.golangci.yml`: **Duplicate rule (cosmetic):** - Removed a duplicate `unnecessary conversion` exclusion that appeared twice. **Dead `unused` suppressions (task #10):** - `` `eventContext` is unused `` — symbol no longer exists in the codebase. - `` `(*DatadogLogger).changeLogLevel` is unused `` — `changeLogLevel` moved to `*loggerPointer` during a refactor; the original type no longer has this method. - `` `defaultRetryDuration` is unused `` — symbol no longer exists. - `` `defaultRetries` is unused `` — symbol is used; the linter wouldn't fire on it regardless. **Dead errcheck exclusion:** - `pem.Encode` — the file that motivated this (`test/integration/utils/certificates.go`) was deleted in #39772. All remaining live `pem.Encode` call sites already check or explicitly ignore the error. **Dead revive exclusion:** - `exported const APIName` — the constant no longer exists in `pkg/serverless/trace/inferredspan/`; the file is also already globally excluded via the `paths` list. **Stale comment fix:** - Updated the comment on the `io.WriteString` errcheck exclusion — its originating file (`tools/dep_tree_resolver/go_deps.go`) was deleted in #22067. The rule itself is kept as it still covers unchecked writes to `http.ResponseWriter`. ### Motivation Dead exclusions accumulate noise in the config and make it harder to reason about which rules are actively suppressing real violations. ### Describe how you validated your changes Ran `dda inv linter.go` — 0 issues. ### Additional Notes Part of a broader linter configuration cleanup pass. Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>

L3n41c added this to the 7.71.0 milestone Aug 12, 2025

L3n41c requested review from a team as code owners August 12, 2025 14:42

L3n41c added [deprecated] team/containers changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Aug 12, 2025

L3n41c force-pushed the lenaic/fix_agent_integration_tests_owner branch from f5c2100 to 8b6fe4e Compare August 12, 2025 14:57

github-actions Bot added the long review PR is complex, plan time to review it label Aug 12, 2025

Fix agent_integration_tests job owner

f23c10b

L3n41c force-pushed the lenaic/fix_agent_integration_tests_owner branch from 8b6fe4e to f23c10b Compare August 12, 2025 15:08

Get rid of agent_integration_tests GitLab job

97677b5

L3n41c changed the title ~~Fix agent_integration_tests job owner~~ Remove the agent_integration_tests GitLab job as it doesn’t run any useful test anymore Aug 12, 2025

alopezz approved these changes Aug 12, 2025

View reviewed changes

L3n41c added the ask-review Ask required teams to review this PR label Aug 12, 2025

sblumenthal approved these changes Aug 12, 2025

View reviewed changes

ofek approved these changes Aug 13, 2025

View reviewed changes

dd-mergequeue Bot merged commit 2bb8882 into main Aug 13, 2025
314 checks passed

dd-mergequeue Bot deleted the lenaic/fix_agent_integration_tests_owner branch August 13, 2025 08:35

pgimalac mentioned this pull request Apr 27, 2026

linter: remove dead exclusion rules from .golangci.yml #49907

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the `agent_integration_tests` GitLab job as it doesn’t run any useful test anymore#39772

Remove the `agent_integration_tests` GitLab job as it doesn’t run any useful test anymore#39772
dd-mergequeue[bot] merged 2 commits intomainfrom
lenaic/fix_agent_integration_tests_owner

L3n41c commented Aug 12, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr Bot commented Aug 12, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter Bot commented Aug 12, 2025 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

L3n41c commented Aug 12, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Aug 12, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr Bot commented Aug 12, 2025 •

edited

Loading

Info

Uh oh!

ofek left a comment

Uh oh!

L3n41c commented Aug 13, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

L3n41c commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

agent-platform-auto-pr Bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gitlab CI Configuration Changes

Removed Jobs

Changes Summary

Uh oh!

cit-pr-commenter Bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

L3n41c commented Aug 12, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-platform-auto-pr Bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

ofek left a comment

Choose a reason for hiding this comment

Uh oh!

L3n41c commented Aug 13, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

L3n41c commented Aug 12, 2025 •

edited

Loading

agent-platform-auto-pr Bot commented Aug 12, 2025 •

edited

Loading

cit-pr-commenter Bot commented Aug 12, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Aug 12, 2025 •

edited

Loading

agent-platform-auto-pr Bot commented Aug 12, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Aug 13, 2025 •

edited

Loading