Skip to content

Remove serverless_cold_start test#37233

Merged
dd-mergequeue[bot] merged 5 commits intomainfrom
kfairise/delete-serverless-cold-start
May 23, 2025
Merged

Remove serverless_cold_start test#37233
dd-mergequeue[bot] merged 5 commits intomainfrom
kfairise/delete-serverless-cold-start

Conversation

@KevinFairise2
Copy link
Copy Markdown
Member

@KevinFairise2 KevinFairise2 commented May 21, 2025

What does this PR do?

Delete serverless_cold_start test.
Was discussed with serverless folks, will be reintroduced in another form, probably using AWS Lambda for real.

https://datadoghq.atlassian.net/browse/SVLS-6864?atlOrigin=eyJpIjoiYzE5ZWQ1NGRhM2VhNDZkMWFjYTdiMzU0MWM0OTkzNzgiLCJwIjoiamlyYS1zbGFjay1pbnQifQ

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@KevinFairise2 KevinFairise2 requested review from a team as code owners May 21, 2025 14:04
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented May 21, 2025

Gitlab CI Configuration Changes

Removed Jobs

  • serverless_cold_start_performance-deb_x64
  • serverless_cold_start_performance-deb_x64_dind

Changes Summary

Removed Modified Added Renamed
2 0 0 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented May 21, 2025

Uncompressed package size comparison

Comparison with ancestor 98436fb7d7f283f8c31d343fc990c003a0990d07

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 773.44MB 773.44MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 782.39MB 782.39MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 782.39MB 782.39MB 0.50MB
datadog-agent-arm64-deb 0.00MB 759.39MB 759.39MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 768.32MB 768.32MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 31.99MB 31.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 30.47MB 30.47MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 380.16MB 380.16MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.71MB 62.71MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.79MB 62.79MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.79MB 62.79MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.28MB 59.28MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.37MB 59.37MB 0.50MB

Decision

✅ Passed

@cit-pr-commenter
Copy link
Copy Markdown

cit-pr-commenter Bot commented May 21, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7f0aee04-ba7a-4fef-88e7-2c04afbb6614

Baseline: 98436fb
Comparison: 94268af
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.48 [+1.42, +1.54] 1 Logs
quality_gate_idle_all_features memory utilization +1.22 [+1.09, +1.35] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.60 [+0.47, +0.74] 1 Logs
quality_gate_logs % cpu utilization +0.53 [-2.10, +3.16] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.32 [+0.21, +0.44] 1 Logs
file_tree memory utilization +0.26 [+0.08, +0.44] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.25 [-0.64, +1.13] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.63, +0.73] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.04 [-0.19, +0.27] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.26, +0.30] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.57, +0.58] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.64, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.62, +0.58] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.65, +0.59] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.67, +0.60] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.07 [-0.71, +0.56] 1 Logs
otlp_ingest_logs memory utilization -0.09 [-0.21, +0.03] 1 Logs
otlp_ingest_metrics memory utilization -0.10 [-0.25, +0.06] 1 Logs
quality_gate_idle memory utilization -0.17 [-0.26, -0.09] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.37 [-0.44, -0.29] 1 Logs
docker_containers_memory memory utilization -0.51 [-0.59, -0.44] 1 Logs
docker_containers_cpu % cpu utilization -0.68 [-4.49, +3.14] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_logs memory_usage 9/10 bounds checks dashboard
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented May 21, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 98436fb

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 DataNotFound $${\color{green}746.16}$$ < $${752.99}$$ DataNotFound $${\color{green}184.72}$$ < $${187.44}$$
agent_deb_amd64_fips DataNotFound $${\color{green}744.52}$$ < $${751.36}$$ DataNotFound $${\color{green}184.14}$$ < $${187.06}$$
agent_heroku_amd64 DataNotFound $${\color{green}368.53}$$ < $${369.68}$$ DataNotFound $${\color{green}98.52}$$ < $${99.55}$$
agent_msi DataNotFound $${\color{green}977.25}$$ < $${978.01}$$ DataNotFound $${\color{green}148.35}$$ < $${149.12}$$
agent_rpm_amd64 DataNotFound $${\color{green}746.15}$$ < $${752.98}$$ DataNotFound $${\color{green}186.41}$$ < $${190.03}$$
agent_rpm_amd64_fips DataNotFound $${\color{green}744.51}$$ < $${751.35}$$ DataNotFound $${\color{green}186.16}$$ < $${189.81}$$
agent_rpm_arm64 DataNotFound $${\color{green}732.73}$$ < $${739.42}$$ DataNotFound $${\color{green}168.38}$$ < $${171.23}$$
agent_rpm_arm64_fips DataNotFound $${\color{green}731.22}$$ < $${737.91}$$ DataNotFound $${\color{green}167.57}$$ < $${170.22}$$
agent_suse_amd64 DataNotFound $${\color{green}746.15}$$ < $${752.98}$$ DataNotFound $${\color{green}186.41}$$ < $${190.03}$$
agent_suse_amd64_fips DataNotFound $${\color{green}744.51}$$ < $${751.35}$$ DataNotFound $${\color{green}186.16}$$ < $${189.81}$$
agent_suse_arm64 DataNotFound $${\color{green}732.73}$$ < $${739.42}$$ DataNotFound $${\color{green}168.38}$$ < $${171.23}$$
agent_suse_arm64_fips DataNotFound $${\color{green}731.22}$$ < $${737.91}$$ DataNotFound $${\color{green}167.57}$$ < $${170.22}$$
docker_agent_amd64 DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_arm64 DataNotFound $${\color{green}839.97}$$ < $${858.97}$$ DataNotFound $${\color{green}267.9}$$ < $${274.36}$$
docker_agent_jmx_amd64 DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_jmx_arm64 DataNotFound $${\color{green}839.97}$$ < $${858.97}$$ DataNotFound $${\color{green}267.9}$$ < $${274.36}$$
docker_agent_windows1809 DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_windows1809_core DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_windows1809_core_jmx DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_windows1809_jmx DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_windows2022 DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_windows2022_core DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_windows2022_core_jmx DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_agent_windows2022_jmx DataNotFound $${\color{green}829.93}$$ < $${849.39}$$ DataNotFound $${\color{green}281.78}$$ < $${288.34}$$
docker_cluster_agent_amd64 DataNotFound $${\color{green}258.93}$$ < $${259.73}$$ DataNotFound $${\color{green}102.78}$$ < $${103.68}$$
docker_cluster_agent_arm64 DataNotFound $${\color{green}273.43}$$ < $${274.24}$$ DataNotFound $${\color{green}97.54}$$ < $${98.45}$$
docker_cws_instrumentation_amd64 DataNotFound $${\color{green}7.08}$$ < $${7.12}$$ DataNotFound $${\color{green}2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 DataNotFound $${\color{green}6.69}$$ < $${6.92}$$ DataNotFound $${\color{green}2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 DataNotFound $${\color{green}38.63}$$ < $${39.57}$$ DataNotFound $${\color{green}14.81}$$ < $${15.76}$$
docker_dogstatsd_arm64 DataNotFound $${\color{green}37.26}$$ < $${38.2}$$ DataNotFound $${\color{green}13.88}$$ < $${14.83}$$
dogstatsd_deb_amd64 DataNotFound $${\color{green}30.58}$$ < $${31.52}$$ DataNotFound $${\color{green}8.03}$$ < $${8.97}$$
dogstatsd_deb_arm64 DataNotFound $${\color{green}29.14}$$ < $${30.08}$$ DataNotFound $${\color{green}6.97}$$ < $${7.92}$$
dogstatsd_rpm_amd64 DataNotFound $${\color{green}30.58}$$ < $${31.52}$$ DataNotFound $${\color{green}8.04}$$ < $${8.98}$$
dogstatsd_suse_amd64 DataNotFound $${\color{green}30.58}$$ < $${31.52}$$ DataNotFound $${\color{green}8.04}$$ < $${8.98}$$
iot_agent_deb_amd64 DataNotFound $${\color{green}59.88}$$ < $${60.17}$$ DataNotFound $${\color{green}14.98}$$ < $${15.82}$$
iot_agent_deb_arm64 DataNotFound $${\color{green}56.61}$$ < $${56.94}$$ DataNotFound $${\color{green}12.85}$$ < $${13.86}$$
iot_agent_deb_armhf DataNotFound $${\color{green}56.06}$$ < $${56.41}$$ DataNotFound $${\color{green}12.97}$$ < $${13.86}$$
iot_agent_rpm_amd64 DataNotFound $${\color{green}59.88}$$ < $${60.18}$$ DataNotFound $${\color{green}14.99}$$ < $${15.84}$$
iot_agent_rpm_arm64 DataNotFound $${\color{green}56.61}$$ < $${56.94}$$ DataNotFound $${\color{green}12.87}$$ < $${13.76}$$
iot_agent_suse_amd64 DataNotFound $${\color{green}59.88}$$ < $${60.18}$$ DataNotFound $${\color{green}14.99}$$ < $${15.84}$$

@github-actions github-actions Bot added the medium review PR review might take time label May 21, 2025
@KevinFairise2 KevinFairise2 added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels May 23, 2025
@KevinFairise2
Copy link
Copy Markdown
Member Author

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented May 23, 2025

View all feedbacks in Devflow UI.

2025-05-23 10:45:36 UTC ℹ️ Start processing command /merge


2025-05-23 10:45:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2025-05-23 11:24:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue Bot merged commit adca716 into main May 23, 2025
286 of 289 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the kfairise/delete-serverless-cold-start branch May 23, 2025 11:24
@github-actions github-actions Bot added this to the 7.68.0 milestone May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants