Conversation
hush-hush
approved these changes
May 19, 2017
Contributor
Author
|
Holding the fire until #259 is merged, will rebase on top of that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The usage of
StickyLockis still very prone to error, the PR contains two minor details to slightly improve the coding conventions that at the moment are the only way to enforce a safe GIL handling:stickyLockis now unexported, was never meant to be used outsidepyfindSubclassOf, meaning you have to do that manually before calling that function. This is coherent with the rest of the code where Exported methods take care of locking while unexported utility functions require the caller to do that.Motivation
Consistency, even if the lack of a mechanism to enforce lock safety is still an issue.