[py/loader] Unlock stickyLock before calling check.Configure#266
Merged
olivielpeau merged 2 commits intomasterfrom May 26, 2017
Merged
[py/loader] Unlock stickyLock before calling check.Configure#266olivielpeau merged 2 commits intomasterfrom
olivielpeau merged 2 commits intomasterfrom
Conversation
`check.Configure` uses its own stickyLock (as the convention of the exported method indicates), so we must unlock our lock before calling it.
I had missed an unlock before a `return` statement. Let's lock and unlock a new stickyLock every time we need it to be on the safe side.
truthbk
approved these changes
May 26, 2017
s-alad
added a commit
that referenced
this pull request
Jan 6, 2026
…266) * Bump github.com/aws/aws-sdk-go-v2/service/ssm from 1.67.3 to 1.67.4 Bumps [github.com/aws/aws-sdk-go-v2/service/ssm](https://github.com/aws/aws-sdk-go-v2) from 1.67.3 to 1.67.4. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ecs/v1.67.3...service/ecs/v1.67.4) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ssm dependency-version: 1.67.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * licenses --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: s-alad <saad.naji@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a regression introduced in #262
check.Configureuses its own stickyLock (as the convention of theexported method indicates), so we must unlock our lock before calling
it.
Motivation
Half of the agent6s installed on staging propjoes are crashing because of this.