[py][utils] Import missing utils modules from Agent 5#310
Merged
Conversation
Only imported the modules that are used by existing integrations-core checks.
hush-hush
approved these changes
Jun 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Imports missing python
utilsmodules from Agent 5 that are used by existingintegrations-corechecks.
Motivation
Ability to run almost all
integrations-corechecks in Agent 6.Additional Notes
These
utilsmodules stand on their own and have no dependency on the core agent, so just copying them from the Agent 5 is fine.Unless I've missed something (which is likely), this should hopefully allow all
integrations-corechecks to run, except:docker_daemon(heavily depends on core-agent-provided features)kubernetes(heavily depends on core-agent-provided features)kubernetes_state(heavily depends on core-agent-provided features)ntp(dep onutils.ntp_util, I haven't added it because the check is a native go check now)Uses the
utils.timermodule from DataDog/dd-agent#3391