[util] Move Timer to its own utils.timer module#3391
Merged
olivielpeau merged 2 commits intomasterfrom Jun 16, 2017
Merged
Conversation
`util.py` is deprecated, and `Timer` was still used in a check (vsphere). Move to `utils`, and still import it in `util` so that custom checks importing it from `util` still work (until we finally remove it in Agent 6.0)
This was referenced Jun 15, 2017
hush-hush
approved these changes
Jun 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move
Timerto its ownutils.timermoduleMotivation
util.pyis deprecated, andTimerwas still used in a check(vsphere). Move to
utils, and still import it inutilso thatcustom checks importing it from
utilstill work (until we finallyremove it in Agent 6.0)
Testing
No specific manual testing done, relying on CI.