Skip to content

[util] Stop using helpers from util, use utils instead#484

Merged
olivielpeau merged 2 commits intomasterfrom
olivielpeau/use-utils
Jun 16, 2017
Merged

[util] Stop using helpers from util, use utils instead#484
olivielpeau merged 2 commits intomasterfrom
olivielpeau/use-utils

Conversation

@olivielpeau
Copy link
Copy Markdown
Member

@olivielpeau olivielpeau commented Jun 15, 2017 •
edited
Loading

What does this PR do?

Apart from headers, the helpers from util are deprecated, let's
use their equivalent from utils instead.

Testing

Relying on existing CI. CI will pass when DataDog/dd-agent#3391, which moves Timer to its own utils.timer module, is merged to master.

Versioning

  • Bumped the version check in manifest.json
  • Updated CHANGELOG.md

@olivielpeau
[util] Stop using helpers from util, use utils instead
2c2f8e8 
Apart from `headers`, the helpers from `util` are deprecated, let's
use their equivalent from `utils` instead.
@olivielpeau olivielpeau added this to the 5.15 milestone Jun 15, 2017
@olivielpeau
Copy link
Copy Markdown
Member Author

olivielpeau commented Jun 16, 2017

DataDog/dd-agent#3391 is merged and CI is green, merging!

@olivielpeau olivielpeau merged commit 2209b0c into master Jun 16, 2017
@olivielpeau olivielpeau deleted the olivielpeau/use-utils branch June 16, 2017 17:03
gml3ff pushed a commit that referenced this pull request May 14, 2020
@iancward @olivielpeau
Add recipe for go-metro integration (#484)
736b884 
Fixes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hush-hush hush-hush hush-hush approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.15

Development

Successfully merging this pull request may close these issues.

2 participants

@olivielpeau @hush-hush