Conversation
gmmeyer
force-pushed
the
greg/elastic
branch
2 times, most recently
from
5aa79e0 to
2426c11
Compare
gmmeyer
force-pushed
the
greg/elastic
branch
3 times, most recently
from
176708c to
333d512
Compare
gmmeyer
force-pushed
the
greg/elastic
branch
2 times, most recently
from
506ca4c to
f76fec1
Compare
sjenriquez
reviewed
Jan 5, 2017
| container_volume = "" | ||
| container_ports = "-p #{container_port1}:#{container_port1} -p #{container_port2}:#{container_port2}" | ||
|
|
||
| sh %(docker run -d #{container_ports} #{container_volume} --name #{container_name} #{docker_image} #{docker_cmd}) |
Contributor
There was a problem hiding this comment.
What's the purpose of container_volume?
Contributor
Author
There was a problem hiding this comment.
Should be removed I didn't end up using it.
sjenriquez
reviewed
Jan 5, 2017
|
|
||
| task cleanup: ['ci:common:cleanup'] do | ||
| # sh %(docker kill #{container_name} 2>/dev/null || true) | ||
| # sh %(docker rm #{container_name} 2>/dev/null || true) |
Contributor
There was a problem hiding this comment.
The cleanup is commented out.
Contributor
Author
There was a problem hiding this comment.
I missed that! Thanks!
sjenriquez
reviewed
Jan 5, 2017
Contributor
sjenriquez
left a comment
sjenriquez
left a comment
There was a problem hiding this comment.
Just a couple small questions/comments.
gmmeyer
force-pushed
the
greg/elastic
branch
2 times, most recently
from
3896905 to
7d39bc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.