[logs] missing method on parser.DecodingParser#6464
Merged
Conversation
prognant
added
changelog/no-changelog
blemale
approved these changes
Sep 28, 2020
tt810
approved these changes
Sep 28, 2020
olivielpeau
approved these changes
Sep 28, 2020
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
LGTM, left a comment that can be addressed later
prognant
force-pushed
the
prognant/decoding-parser-missing-method
branch
from
9142a75 to
4d679a6
Compare
olivielpeau
approved these changes
Sep 28, 2020
prognant
added a commit
that referenced
this pull request
Sep 28, 2020
prognant
added a commit
that referenced
this pull request
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a missing method and a relevant test.
Method was missing because of a complex rebase (#6265).
Motivation
Fix a possible crash.
Additional Notes
N/A.
Describe your test plan
Test that utf-16 log tailing works.