[logs/AD] Logs tailing from docker label#6883
Merged
Conversation
prognant
added
do-not-merge/WIP
[deprecated] team/agent-core
prognant
force-pushed
the
prognant/AD-logs-tailing-from-docker-label
branch
from
fa4d084 to
620ec79
Compare
prognant
force-pushed
the
prognant/AD-logs-tailing-from-docker-label
branch
from
620ec79 to
700d62a
Compare
remeh
approved these changes
Dec 9, 2020
Contributor
remeh
left a comment
remeh
left a comment
There was a problem hiding this comment.
Concise and working change, successfully tested locally. 👍
Merged
3 tasks
This was referenced Jan 12, 2021
sergei-deliveroo
pushed a commit
to deliveroo/datadog-agent
that referenced
this pull request
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support file tailing logs config coming from docker label.
Motivation
Extend supported logs config coming from AD.
Additional Notes
Checklist:
agent statusoutput & GUI ✅Identifiervalue, stick to<container_id>or✅container_id://<container_id>and stop using the otherNote: file path shall be relative to where the agent is running.
Note #2: registry key are not impacted by the small rework on how
Identifieris populated (the registry uses the tailer identifier that is not impacted by the change)Describe your test plan
Manual test on K8s ✅