Update docker logs collection with AD label supporting file tailing#9235
Merged
Update docker logs collection with AD label supporting file tailing#9235
Conversation
ruthnaebeck
suggested changes
Dec 10, 2020
Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
Contributor
|
@cohenyair Did a review of the content and this looks great! 👍 I'll let Ruth finalize the review as she requested previous changes during the editorial review. |
Contributor
|
@prognant Hi there! Checking in on status: are we okay to merge this now that the feature is released, or are we waiting on additional merges? |
Contributor
Author
|
Hi @sarina-dd, the agent release (7.25.0) targeted by this documentation PR is due for release soon (unsure exactly when), If that's ok I can ping you here as soon as we get 7.25.0 out ? |
Contributor
|
@prognant Yep, sounds good 👍 Just ping me whenever we're ready and I can publish. Thanks for this! |
Contributor
Author
|
Hi @sarina-dd, the Agent v7.25.0 so you can now merge this PR ! |
sarina-dd
approved these changes
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Document new feature coming with Agent 7.25.0 (DataDog/datadog-agent#6883).
Motivation
Keep doc up-to-date.
Preview
https://docs-staging.datadoghq.com/prognant/file-tailing-from-docker-AD-label/agent/docker/log/
Additional Notes
It will be available for agent >= 7.25 (will be available around the beginning of the year)
Reviewer checklist