feat(bottlecap): set error to invocation span#444
Merged
duncanista merged 6 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Nov 12, 2024
Conversation
checks the headers to identify errors that should be attatched to the invocation span and the inferred span
duncanista
changed the base branch from
main
to
jordan.gonzalez/bottlecap/universal-instrumentation
…to jordan.gonzalez/bottlecap/invocation-span-error-message
alexgallotta
approved these changes
Nov 11, 2024
duncanista
merged commit ef864f9
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
deleted the
jordan.gonzalez/bottlecap/invocation-span-error-message
branch
duncanista
added a commit
that referenced
this pull request
Nov 15, 2024
* move `base64_to_string` to `lifecycle::invocation` module * set error on span from headers checks the headers to identify errors that should be attatched to the invocation span and the inferred span * increment metrics on error * fmt * remove a todo
duncanista
added a commit
that referenced
this pull request
Nov 19, 2024
* move `base64_to_string` to `lifecycle::invocation` module * set error on span from headers checks the headers to identify errors that should be attatched to the invocation span and the inferred span * increment metrics on error * fmt * remove a todo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Uses the error data sent by traces to attach it to the invocation span.
How
Using the headers data sent by the tracers on end invocation, also sends a metric.
Notes