chore(bottlecap): move EnhancedMetrics to live in InvocationProcessor#446
Merged
duncanista merged 2 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Nov 11, 2024
Conversation
shreyamalpani
approved these changes
Nov 11, 2024
duncanista
merged commit 00360bf
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
deleted the
jordan.gonzalez/bottlecap/refactor-enhanced-metrics-calls
branch
duncanista
added a commit
that referenced
this pull request
Nov 15, 2024
…sor` (#446) * move `EnhancedMetrics` to live in `InvocationProcessor` * rename field to `enhanced_metrics_enabled`
duncanista
added a commit
that referenced
this pull request
Nov 19, 2024
…sor` (#446) * move `EnhancedMetrics` to live in `InvocationProcessor` * rename field to `enhanced_metrics_enabled`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Moves where enhanced metrics are being called to be aggregated.
Why?
Reduce the footprint in
main.rs, and to have more control over the whole invocation lifecycle.Also unblocks #444